Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for vertical polygons #6791

Merged
merged 8 commits into from Jul 16, 2018

Conversation

Projects
None yet
4 participants
@hpinkos
Copy link
Contributor

hpinkos commented Jul 10, 2018

Fixes #3349

We can now render this crazy KML file:
image

I connected CoplanarPolygonGeometry to the Entity API.
We use it instead of PolygonGeometry when perPositionHeight: true and extrudedHeight: undefined.

TODO

  • Merge #6787
  • Update CHANGES
@cesium-concierge

This comment has been minimized.

Copy link

cesium-concierge commented Jul 10, 2018

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato

This comment has been minimized.

Copy link
Member

mramato commented Jul 11, 2018

Update CHANGES and specifically mention that this improves KML compatibility.

@hpinkos

This comment has been minimized.

Copy link
Contributor Author

hpinkos commented Jul 12, 2018

@mramato this is ready now

viewer.zoomTo(viewer.entities);
//Sandcastle_End
var cyanPolygon = viewer.entities.add({
name : 'Orange polygon with per-position heights and outline',

This comment has been minimized.

Copy link
@mramato

mramato Jul 13, 2018

Member

This name needs to be updated.

@mramato

This comment has been minimized.

Copy link
Member

mramato commented Jul 14, 2018

Can we add a test for this? The rest of the updater is pretty well covered by tests I believe.

@mramato

This comment has been minimized.

Copy link
Member

mramato commented Jul 14, 2018

Looks great @hpinkos, just those couple of comments.

@hpinkos

This comment has been minimized.

Copy link
Contributor Author

hpinkos commented Jul 16, 2018

@mramato ready

@mramato

This comment has been minimized.

Copy link
Member

mramato commented Jul 16, 2018

Thanks @hpinkos!

@mramato mramato merged commit d403745 into master Jul 16, 2018

5 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deployment Deployed
Details
npm package Deployed
Details
zip file Deployed
Details

@mramato mramato deleted the entity-polygon branch Jul 16, 2018

@silky

This comment has been minimized.

Copy link

silky commented Jul 16, 2018

thanks for adding this @hpinkos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.