Strings "true" and "false" converted to booleans in plugin settings

[matthewdean]

Run this code with the command bar:

local value = "true"
print(type(value))
--> string

local plugin = PluginManager():CreatePlugin()
plugin:SetSetting("key", value)
value = plugin:GetSetting("key")
print(type(value))
--> boolean

[chc4]

Does this actually matter, since Lua has type juggling? Plugins store settings in a JSON format, so unless they add a "type" attribute to all the fields I don't see a problem.

[Anaminus]

I think the point is that the JSON encoder for plugin settings (which is apparently not the HTTP JSON encoder) is wildly inconsistent.

[matthewdean]

@chc4 true is a valid JSON literal so there's no need to convert it to a string when serializing.

[einsteinK]

A plugin creator shouldn't use "true" and "false" as strings, though, but as booleans.

The only "issue" that could possibly happen, is that "false" counts as true, and false doesn't.
(But unless the loaded data is MENT to be a string, and it's converted to boolean, problem)