Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs for multiple complete bible screen setups #245

Closed
tuomas2 opened this issue Jan 26, 2019 · 7 comments · Fixed by #355
Closed

Tabs for multiple complete bible screen setups #245

tuomas2 opened this issue Jan 26, 2019 · 7 comments · Fixed by #355

Comments

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 26, 2019

Implement chrome-like tabs, that can contain whole bible screen (including all their splitted windows) setups.

@tuomas2 tuomas2 changed the title UI / UX: tabs for complete window setup Tabs for multiple complete bible screen setups Jan 26, 2019
@tuomas2 tuomas2 self-assigned this Apr 25, 2019
tuomas2 added a commit that referenced this issue May 23, 2019
@tuomas2
Copy link
Contributor Author

tuomas2 commented May 23, 2019

Will be implemented in build 308

@bvahedy
Copy link

bvahedy commented May 24, 2019

Verified tabs working in 308beta. I also checked to make sure each tab carries it's own history. The only issue I have is that it takes going through 2 menus to select a tab. Other than that it's a nice addition.

@timbze
Copy link
Contributor

timbze commented May 24, 2019

@bvahedy You can swipe down on reference title to open tabs list. Or swipe left/right on it to jump between tabs. A bit like Google Chrome on phone works.

@tuomas2 A suggestion I would have is to possibly add Close X button at tabs list to easily close a tab. But more important for me would be to add a + somewhere to add another tab easily from there, instead of having to go to the menu to open new tab.

@bvahedy
Copy link

bvahedy commented May 24, 2019 via email

@timbze
Copy link
Contributor

timbze commented May 24, 2019

Thanks to Tuomas. He did all the work on this.

@bvahedy
Copy link

bvahedy commented May 24, 2019 via email

@tuomas2
Copy link
Contributor Author

tuomas2 commented May 24, 2019

Opened follow-up ticket, let's collect improvement suggestions there #368

@tuomas2 tuomas2 added this to the v3.2 milestone May 24, 2019
@bvahedy bvahedy removed their assignment Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants