New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTAGS_BUILD_CLANG=1 broken right now #1089

Open
jbeigel opened this Issue Nov 8, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@jbeigel
Contributor

jbeigel commented Nov 8, 2017

Please mark appropriate

  • rtags (rdm/rc/rp)
  • Emacs Lisp
    • ac-rtags.el
    • company-rtags.el
    • helm-rtags.el
    • flycheck-rtags.el
    • ivy-rtags.el
    • rtags.el

Problem description

Unless I'm doing something wrong, the feature to download and build clang as part of the rtags build seems to be broken right now.

There are several errors in scripts/getclang.sh:

  • the URL has changed to, but curl does not follow the HTTP 302 response (instead saves HTML files containing the 302 response)
  • ${URL} is set, but then not used
  • ${VERSION} vs. ${version}

Furthermore, and a lot more puzzling: I was not able to even trigger the ExternalProject_Add step (and thus the getclang.sh script, plus the subsequent build) by specifying -DRTAGS_BUILD_CLANG=1. I was not able to find out, why this seems to be a complete no-op in my case, but (by inserting message statements immediately before and after the ExternalProject_Add, outputting cmake variables...) I can see that the correct code path in src/CMakeLists.txt is taken.

When I downloaded clang manually by fixing/simulating the getclang.sh script and tried to build it by simply doing "cmake [parameters specified in ExternalProject_Add]" inside the llvm/ directory directly, I got an error together with the hint to create a subdirectory and issue cmake from there. This makes sense, rtags advises the same in the README.txt, but I don't know if ExternalProject_Add can cope with this, too.

Expected behavior

"cd build && cmake -DRTAGS_BUILD_CLANG=1 .." should work.

Environment

SuSE Linux Enterprise Server 12 SP 2
tested with cmake 3.5.2 and cmake 3.9.4

Andersbakken added a commit that referenced this issue Nov 10, 2017

@Andersbakken

This comment has been minimized.

Show comment
Hide comment
@Andersbakken

Andersbakken Nov 10, 2017

Owner

I have't tested this in ages. I think it should work again now. Can you test for me? I pushed a fix (that also updates to 5.0.0 and removes the manual checksum validation since llvm finally hosts these on https.

Owner

Andersbakken commented Nov 10, 2017

I have't tested this in ages. I think it should work again now. Can you test for me? I pushed a fix (that also updates to 5.0.0 and removes the manual checksum validation since llvm finally hosts these on https.

@jbeigel

This comment has been minimized.

Show comment
Hide comment
@jbeigel

jbeigel Nov 11, 2017

Contributor

Hi,

Yes, now it works. Thanks for fixing this so quickly!

(Any idea why ExternalProject_Add didn't have any effect and didn't even call the download script? The fact that I couldn't find out why, is the reason why I couldn't be of much help in fixing this.)

One - possibly minor - point that was still left: It seems like the llvm-clang-stuff gets installed already as part of a "make" (i.e. before "make install"). And it tried to install to "/var/empty/local/..." which doens't even exist. I fixed this by specifying CMAKE_INSTALL_PREFIX and giving the target directory write permissions of the normal user.

-- Johannes

Contributor

jbeigel commented Nov 11, 2017

Hi,

Yes, now it works. Thanks for fixing this so quickly!

(Any idea why ExternalProject_Add didn't have any effect and didn't even call the download script? The fact that I couldn't find out why, is the reason why I couldn't be of much help in fixing this.)

One - possibly minor - point that was still left: It seems like the llvm-clang-stuff gets installed already as part of a "make" (i.e. before "make install"). And it tried to install to "/var/empty/local/..." which doens't even exist. I fixed this by specifying CMAKE_INSTALL_PREFIX and giving the target directory write permissions of the normal user.

-- Johannes

@s-f-s

This comment has been minimized.

Show comment
Hide comment
@s-f-s

s-f-s Aug 22, 2018

It seems this is broken again on current master. Should we re-open this ticket?

s-f-s commented Aug 22, 2018

It seems this is broken again on current master. Should we re-open this ticket?

@cslux cslux reopened this Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment