Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
RTAGS_BUILD_CLANG=1 broken right now #1089
Please mark appropriate
Unless I'm doing something wrong, the feature to download and build clang as part of the rtags build seems to be broken right now.
There are several errors in scripts/getclang.sh:
Furthermore, and a lot more puzzling: I was not able to even trigger the ExternalProject_Add step (and thus the getclang.sh script, plus the subsequent build) by specifying -DRTAGS_BUILD_CLANG=1. I was not able to find out, why this seems to be a complete no-op in my case, but (by inserting message statements immediately before and after the ExternalProject_Add, outputting cmake variables...) I can see that the correct code path in src/CMakeLists.txt is taken.
When I downloaded clang manually by fixing/simulating the getclang.sh script and tried to build it by simply doing "cmake [parameters specified in ExternalProject_Add]" inside the llvm/ directory directly, I got an error together with the hint to create a subdirectory and issue cmake from there. This makes sense, rtags advises the same in the README.txt, but I don't know if ExternalProject_Add can cope with this, too.
"cd build && cmake -DRTAGS_BUILD_CLANG=1 .." should work.
SuSE Linux Enterprise Server 12 SP 2
added a commit
Nov 10, 2017
Yes, now it works. Thanks for fixing this so quickly!
(Any idea why ExternalProject_Add didn't have any effect and didn't even call the download script? The fact that I couldn't find out why, is the reason why I couldn't be of much help in fixing this.)
One - possibly minor - point that was still left: It seems like the llvm-clang-stuff gets installed already as part of a "make" (i.e. before "make install"). And it tried to install to "/var/empty/local/..." which doens't even exist. I fixed this by specifying CMAKE_INSTALL_PREFIX and giving the target directory write permissions of the normal user.