From 0f8e1bc2e133f1362e20a2146fe307170a38499f Mon Sep 17 00:00:00 2001 From: AndiAJ Date: Wed, 29 Sep 2021 12:11:15 +0300 Subject: [PATCH] For #21478 fix flaky verifyOpenTopSiteNormalTab UI test --- .../androidTest/java/org/mozilla/fenix/ui/TopSitesTest.kt | 8 ++------ .../java/org/mozilla/fenix/ui/robots/BrowserRobot.kt | 1 + 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/TopSitesTest.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/TopSitesTest.kt index f27a8dfd471b..a59d38ef594d 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/TopSitesTest.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/TopSitesTest.kt @@ -83,16 +83,12 @@ class TopSitesTest { verifyAddToTopSitesButton() }.addToFirefoxHome { verifySnackBarText("Added to top sites!") - }.openTabDrawer { - }.openNewTab { - }.dismissSearchBar { + }.goToHomescreen { verifyExistingTopSitesList() verifyExistingTopSitesTabs(defaultWebPageTitle) }.openTopSiteTabWithTitle(title = defaultWebPageTitle) { verifyUrl(defaultWebPage.url.toString().replace("http://", "")) - }.openTabDrawer { - }.openNewTab { - }.dismissSearchBar { + }.goToHomescreen { verifyExistingTopSitesList() verifyExistingTopSitesTabs(defaultWebPageTitle) }.openContextMenuOnTopSitesWithTitle(defaultWebPageTitle) { diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt index 8f347570aef5..94c9c60d4308 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt @@ -533,6 +533,7 @@ class BrowserRobot { onView(withContentDescription("Home screen")) .check(matches(isDisplayed())) .click() + mDevice.waitForIdle() HomeScreenRobot().interact() return HomeScreenRobot.Transition()