Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixed compilation on windows #1
Conversation
praisethemoon
added some commits
Dec 27, 2016
praisethemoon
commented
Dec 27, 2016
|
Update: Fixed compilation error for visual studio below 2015. The issue was, |
|
Thanks - I've merged them in a slightly different way, but hopefully this has the same effect for you. I moved the inline statement into the .c file, since it doesn't have anything to do with the external API, and I just inlined the localtime_r stuff, since we only call it once. Hope this is sufficient - thanks for the feedback, always nice to hear from people using this. |
AndreRenaud
closed this
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
praisethemoon commentedDec 27, 2016
Hello, I'm using this library for my programming language to generate report from the compilation process, and I noticed it does not work on Windows.
I used the fix proposed here https://bugs.webkit.org/show_bug.cgi?id=5311 Which implements
localtime_rand removedunistdinclusion on Windows platform.By the way, this is my first PR on github😺 .
Cheers!