Guard against error #1

Merged
merged 2 commits into from Feb 11, 2014

Conversation

Projects
None yet
2 participants
@cdnbacon
Contributor

cdnbacon commented Feb 5, 2014

Error, exact repro not yet clear. Happens in Asserts and when using bluebird promises.

TypeError: Cannot read property '0' of undefined
    at /home/ubuntu/public-website/node_modules/clarify/clarify.js:10:35
    at Array.0 (/home/ubuntu/public-website/node_modules/clarify/clarify.js:9:17)
    at TraceModifier._modify (/home/ubuntu/public-website/node_modules/clarify/node_modules/stack-chain/stack-chain.js:41:32)
    at Function.Error.prepareStackTrace (/home/ubuntu/public-website/node_modules/clarify/node_modules/stack-chain/stack-chain.js:81:25)

cdnbacon added some commits Feb 5, 2014

Guard against error
Error, repro not yet clear

```
TypeError: Cannot read property '0' of undefined
    at /home/ubuntu/public-website/node_modules/clarify/clarify.js:10:35
    at Array.0 (/home/ubuntu/public-website/node_modules/clarify/clarify.js:9:17)
    at TraceModifier._modify (/home/ubuntu/public-website/node_modules/clarify/node_modules/stack-chain/stack-chain.js:41:32)
    at Function.Error.prepareStackTrace (/home/ubuntu/public-website/node_modules/clarify/node_modules/stack-chain/stack-chain.js:81:25)
```
Update package.json
Reflect bug fix.
@AndreasMadsen

This comment has been minimized.

Show comment Hide comment
@AndreasMadsen

AndreasMadsen Feb 5, 2014

Owner

Thanks, this makes perfect sense. But I would like a test case. I assume it would something like eval('throw new Error()') or vm.runInThisContext('throw new Error()') without being certain.

Otherwise you can post a testcase there uses bluebird promises and I will try looking at it, but I'm not yet familiar with it bluebird promises.

Owner

AndreasMadsen commented Feb 5, 2014

Thanks, this makes perfect sense. But I would like a test case. I assume it would something like eval('throw new Error()') or vm.runInThisContext('throw new Error()') without being certain.

Otherwise you can post a testcase there uses bluebird promises and I will try looking at it, but I'm not yet familiar with it bluebird promises.

AndreasMadsen added a commit that referenced this pull request Feb 11, 2014

@AndreasMadsen AndreasMadsen merged commit 2cd35d5 into AndreasMadsen:master Feb 11, 2014

1 check passed

default The Travis CI build passed
Details
@AndreasMadsen

This comment has been minimized.

Show comment Hide comment
@AndreasMadsen

AndreasMadsen Feb 11, 2014

Owner

Added the test myself.

Owner

AndreasMadsen commented Feb 11, 2014

Added the test myself.

@AndreasMadsen

This comment has been minimized.

Show comment Hide comment
@AndreasMadsen

AndreasMadsen Feb 11, 2014

Owner

published to npm now. Thanks for contributing.

Owner

AndreasMadsen commented Feb 11, 2014

published to npm now. Thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment