Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

domain: document and test dispose event

  • Loading branch information...
commit 4f0ecba0c7716b15ac52ed449a24fe906a52ce92 1 parent e00adf3
@AndreasMadsen authored
View
2  doc/api/domain.markdown
@@ -258,6 +258,8 @@ The intention of calling `dispose` is generally to prevent cascading
errors when a critical part of the Domain context is found to be in an
error state.
+Once the domain is disposed the `dispose` event will emit.
+
Note that IO might still be performed. However, to the highest degree
possible, once a domain is disposed, further errors from the emitters in
that set will be ignored. So, even if some remaining actions are still
View
8 test/simple/test-domain-http-server.js
@@ -28,7 +28,8 @@ var objects = { foo: 'bar', baz: {}, num: 42, arr: [1,2,3] };
objects.baz.asdf = objects;
var serverCaught = 0;
-var clientCaught = 0
+var clientCaught = 0;
+var disposeEmit = 0;
var server = http.createServer(function(req, res) {
var dom = domain.create();
@@ -84,6 +85,10 @@ function next() {
dom.dispose();
});
+ dom.on('dispose', function() {
+ disposeEmit += 1;
+ });
+
var req = http.get({ host: 'localhost', port: common.PORT, path: p });
dom.add(req);
req.on('response', function(res) {
@@ -111,5 +116,6 @@ function next() {
process.on('exit', function() {
assert.equal(serverCaught, 2);
assert.equal(clientCaught, 2);
+ assert.equal(disposeEmit, 2);
console.log('ok');
});
Please sign in to comment.
Something went wrong with that request. Please try again.