Permalink
Browse files

test: add and assert readable/writable arguments

Currently the readable and writable arguments are not specified in the
req.oncomplete method. Adding and asserting that they are always true
(which is always the case for TCP). This might seem unnecessary but it
can't hurt to have them to pickup any breaking modifications made to
ConnectionWrap::AfterConnect in the future.

PR-URL: nodejs#8815
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
1 parent c8c2544 commit 3c5cf12709b22e4410bc3e0e068dc423740ac981 @danbev danbev committed Sep 27, 2016
Showing with 14 additions and 16 deletions.
  1. +14 −16 test/parallel/test-tcp-wrap-connect.js
@@ -10,23 +10,23 @@ function makeConnection() {
var req = new TCPConnectWrap();
var err = client.connect(req, '127.0.0.1', this.address().port);
- assert.equal(err, 0);
+ assert.strictEqual(err, 0);
- req.oncomplete = function(status, client_, req_) {
- assert.equal(0, status);
- assert.equal(client, client_);
- assert.equal(req, req_);
+ req.oncomplete = function(status, client_, req_, readable, writable) {
+ assert.strictEqual(0, status);
+ assert.strictEqual(client, client_);
+ assert.strictEqual(req, req_);
+ assert.strictEqual(true, readable);
+ assert.strictEqual(true, writable);
- console.log('connected');
var shutdownReq = new ShutdownWrap();
var err = client.shutdown(shutdownReq);
- assert.equal(err, 0);
+ assert.strictEqual(err, 0);
shutdownReq.oncomplete = function(status, client_, req_) {
- console.log('shutdown complete');
- assert.equal(0, status);
- assert.equal(client, client_);
- assert.equal(shutdownReq, req_);
+ assert.strictEqual(0, status);
+ assert.strictEqual(client, client_);
+ assert.strictEqual(shutdownReq, req_);
shutdownCount++;
client.close();
};
@@ -40,11 +40,9 @@ var endCount = 0;
var shutdownCount = 0;
var server = require('net').Server(function(s) {
- console.log('got connection');
connectCount++;
s.resume();
s.on('end', function() {
- console.log('got eof');
endCount++;
s.destroy();
server.close();
@@ -54,7 +52,7 @@ var server = require('net').Server(function(s) {
server.listen(0, makeConnection);
process.on('exit', function() {
- assert.equal(1, shutdownCount);
- assert.equal(1, connectCount);
- assert.equal(1, endCount);
+ assert.strictEqual(1, shutdownCount);
+ assert.strictEqual(1, connectCount);
+ assert.strictEqual(1, endCount);
});

0 comments on commit 3c5cf12

Please sign in to comment.