Adding importDir option to clientScript component #1

Merged
merged 3 commits into from Dec 10, 2012

Projects

None yet

2 participants

@rolies106

Hi,

I made some little changes in your component, I put importDir option to component as you can see at readme files. This because I got some problem when using @import "filename" in my less, it always didn't do the import thing, but after I set import dir to class it running well, maybe you want to test it first to fulfill your standard.

and by the way I'm also change all your Readme.md content from HTML to MarkDown to make it lot easier to read if you don't mind.

Thanks.

@Andrekra
Owner

Hi, Thank you for your commit and sorry I haven't responded sooner. I completely missed the notification.

This pull request all seems in order. Perhaps use CMap::mergeArray($this->importDir, array(dirname($input))); But on the other hand, $this->importDir will never have multiple arrays.

I'll merge it, thank you for your contribution!

@Andrekra Andrekra merged commit 2e34e9c into Andrekra:master Dec 10, 2012
@rolies106

Thanks for your merge, glad I could give some contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment