New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting lumber now works incorrectly #66

Closed
KroArtem opened this Issue Feb 8, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@KroArtem

KroArtem commented Feb 8, 2016

After you last changes to lumber collection strategy, there is a nasty bug (found it only now). When miners "finish" one piece of tree, they seem to be looking for the nearest tree to lumber mill/town hall, but if it is unreachable, they just do nothing.

screenshot from 2016-02-08 20 45 13

lumberjacks doing nothing.sav.zip

Andrettin added a commit that referenced this issue Feb 9, 2016

@Andrettin

This comment has been minimized.

Show comment
Hide comment
@Andrettin

Andrettin Feb 9, 2016

Owner

Thanks for reporting this :)

The bug wasn't caused by the latest change to lumber collection (since that only affected tree tiles rather than objects like wood piles). The bug was probably just not noticed until now because it requires a very specific placement of the lumber mill, the wood piles and the blocking buildings.

I've implemented a fix to the issue:
a5f0c79

If you load your save game, the miners will get right back to work now.

Owner

Andrettin commented Feb 9, 2016

Thanks for reporting this :)

The bug wasn't caused by the latest change to lumber collection (since that only affected tree tiles rather than objects like wood piles). The bug was probably just not noticed until now because it requires a very specific placement of the lumber mill, the wood piles and the blocking buildings.

I've implemented a fix to the issue:
a5f0c79

If you load your save game, the miners will get right back to work now.

@Andrettin Andrettin closed this Feb 9, 2016

@KroArtem

This comment has been minimized.

Show comment
Hide comment
@KroArtem

KroArtem Feb 9, 2016

Ok, that was hard to detect, indeed.

One question not related to this ticket. Do you have any plans regarding localization? I saw some .po files in translation folder, but they're not used, as far as I understand. Is it worth doing? Do you think about stabilizing story/quests so it'll be a string freeze? Is there any sense translating all these names onto other languages?
These are just my thoughts, no need to answer them all. :)

KroArtem commented Feb 9, 2016

Ok, that was hard to detect, indeed.

One question not related to this ticket. Do you have any plans regarding localization? I saw some .po files in translation folder, but they're not used, as far as I understand. Is it worth doing? Do you think about stabilizing story/quests so it'll be a string freeze? Is there any sense translating all these names onto other languages?
These are just my thoughts, no need to answer them all. :)

@Andrettin

This comment has been minimized.

Show comment
Hide comment
@Andrettin

Andrettin Feb 9, 2016

Owner

There were plans to localize the game in some other languages, but they were abandoned because of the workload required to maintain the localizations (since every time a string is changed the localizations would need to be update); and it would also delay the release of new versions.

It would be pretty nice to have the game translated into other languages, but there are these practical impediments.

Owner

Andrettin commented Feb 9, 2016

There were plans to localize the game in some other languages, but they were abandoned because of the workload required to maintain the localizations (since every time a string is changed the localizations would need to be update); and it would also delay the release of new versions.

It would be pretty nice to have the game translated into other languages, but there are these practical impediments.

@KroArtem

This comment has been minimized.

Show comment
Hide comment
@KroArtem

KroArtem Feb 9, 2016

Yeah, that's why I asked about string freeze (and you do update strings a lot). Updating stuff could be more or less automated (like, generating new .po/pot file and loading it to transifex and downloading already done translations into repository), but it won't guarantee that everything is translated/translated correctly.

It will also bring some problems with fonts. I remember in SuperTuxKart we had some problems with Russian translation, then RTL problems, then Chinese support problem... so I'm ok with English version, the question is whether it is acceptable for you. :)

KroArtem commented Feb 9, 2016

Yeah, that's why I asked about string freeze (and you do update strings a lot). Updating stuff could be more or less automated (like, generating new .po/pot file and loading it to transifex and downloading already done translations into repository), but it won't guarantee that everything is translated/translated correctly.

It will also bring some problems with fonts. I remember in SuperTuxKart we had some problems with Russian translation, then RTL problems, then Chinese support problem... so I'm ok with English version, the question is whether it is acceptable for you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment