New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make each song its own file #38

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@rspeicher

rspeicher commented Feb 7, 2012

Each song is a slugified artist-track YAML file in the songs directory, containing artist, track and url keys. Should simplify pull requests for adding songs.

There is a TODO in the Songs class, I thought I'd let you decide what to do in the case that the requested data file doesn't exist.

Addresses #28

rspeicher added some commits Feb 7, 2012

Make each song its own file
Each song is a slugified artist-track YAML file in the songs directory,
containing artist, track and url keys. Should simplify pull requests for
adding songs.
@BPScott

This comment has been minimized.

Show comment
Hide comment
@BPScott

BPScott Feb 7, 2012

Good stuff, very similar to how I was going to implement this.

I'd lean towards keeping the artist / title split in the slug rather than concatenating with a hyphen -
songs/animal-collective/summertime-clothes.yml instead of songs/animal-collective-summertime-clothes.yml but that's personal preference and trivial to change

If people want to play around with different formats for the song files, here's a converter that takes the current songs.rb and spits out .yml files.

BPScott commented Feb 7, 2012

Good stuff, very similar to how I was going to implement this.

I'd lean towards keeping the artist / title split in the slug rather than concatenating with a hyphen -
songs/animal-collective/summertime-clothes.yml instead of songs/animal-collective-summertime-clothes.yml but that's personal preference and trivial to change

If people want to play around with different formats for the song files, here's a converter that takes the current songs.rb and spits out .yml files.

@AndrewVos

This comment has been minimized.

Show comment
Hide comment
@AndrewVos

AndrewVos Feb 8, 2012

Owner

Sadly I've already started writing some code that stores all songs in a database, and allows submissions on the main page. Should get it finished during lunch tomorrow.

Sorry :/

Owner

AndrewVos commented Feb 8, 2012

Sadly I've already started writing some code that stores all songs in a database, and allows submissions on the main page. Should get it finished during lunch tomorrow.

Sorry :/

@rspeicher

This comment has been minimized.

Show comment
Hide comment
@rspeicher

rspeicher Feb 8, 2012

@BPScott Good call on Dir.glob, I suspected there was a better way to do it.

@AndrewVos No worries. As I was working on it, it seemed inevitable to eventually end up in a database.

rspeicher commented Feb 8, 2012

@BPScott Good call on Dir.glob, I suspected there was a better way to do it.

@AndrewVos No worries. As I was working on it, it seemed inevitable to eventually end up in a database.

@AndrewVos AndrewVos closed this Feb 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment