Skip to content

Commit

Permalink
remove unused softirq_action callback parameter
Browse files Browse the repository at this point in the history
Extracted from PaX.
  • Loading branch information
thestinger committed May 26, 2018
1 parent d39553d commit 0d054ac
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion block/blk-softirq.c
Expand Up @@ -20,7 +20,7 @@ static DEFINE_PER_CPU(struct list_head, blk_cpu_done);
* Softirq action handler - move entries to local list and loop over them
* while passing them to the queue registered handler.
*/
static __latent_entropy void blk_done_softirq(struct softirq_action *h)
static __latent_entropy void blk_done_softirq(void)
{
struct list_head *cpu_list, local_list;

Expand Down
2 changes: 1 addition & 1 deletion drivers/misc/lkdtm_core.c
Expand Up @@ -78,7 +78,7 @@ static irqreturn_t jp_handle_irq_event(unsigned int irq,
return 0;
}

static void jp_tasklet_action(struct softirq_action *a)
static void jp_tasklet_action(void)
{
lkdtm_handler();
jprobe_return();
Expand Down
4 changes: 2 additions & 2 deletions include/linux/interrupt.h
Expand Up @@ -485,7 +485,7 @@ extern const char * const softirq_to_name[NR_SOFTIRQS];

struct softirq_action
{
void (*action)(struct softirq_action *);
void (*action)(void);
};

asmlinkage void do_softirq(void);
Expand All @@ -500,7 +500,7 @@ static inline void do_softirq_own_stack(void)
}
#endif

extern void __init open_softirq(int nr, void (*action)(struct softirq_action *));
extern void __init open_softirq(int nr, void (*action)(void));
extern void softirq_init(void);
extern void __raise_softirq_irqoff(unsigned int nr);

Expand Down
2 changes: 1 addition & 1 deletion kernel/rcu/tiny.c
Expand Up @@ -164,7 +164,7 @@ static void __rcu_process_callbacks(struct rcu_ctrlblk *rcp)
}
}

static __latent_entropy void rcu_process_callbacks(struct softirq_action *unused)
static __latent_entropy void rcu_process_callbacks(void)
{
__rcu_process_callbacks(&rcu_sched_ctrlblk);
__rcu_process_callbacks(&rcu_bh_ctrlblk);
Expand Down
2 changes: 1 addition & 1 deletion kernel/rcu/tree.c
Expand Up @@ -2918,7 +2918,7 @@ __rcu_process_callbacks(struct rcu_state *rsp)
/*
* Do RCU core processing for the current CPU.
*/
static __latent_entropy void rcu_process_callbacks(struct softirq_action *unused)
static __latent_entropy void rcu_process_callbacks(void)
{
struct rcu_state *rsp;

Expand Down
2 changes: 1 addition & 1 deletion kernel/sched/fair.c
Expand Up @@ -8986,7 +8986,7 @@ static void nohz_idle_balance(struct rq *this_rq, enum cpu_idle_type idle) { }
* run_rebalance_domains is triggered when needed from the scheduler tick.
* Also triggered for nohz idle balancing (with nohz_balancing_kick set).
*/
static __latent_entropy void run_rebalance_domains(struct softirq_action *h)
static __latent_entropy void run_rebalance_domains(void)
{
struct rq *this_rq = this_rq();
enum cpu_idle_type idle = this_rq->idle_balance ?
Expand Down
8 changes: 4 additions & 4 deletions kernel/softirq.c
Expand Up @@ -281,7 +281,7 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
kstat_incr_softirqs_this_cpu(vec_nr);

trace_softirq_entry(vec_nr);
h->action(h);
h->action();
trace_softirq_exit(vec_nr);
if (unlikely(prev_count != preempt_count())) {
pr_err("huh, entered softirq %u %s %p with preempt_count %08x, exited with %08x?\n",
Expand Down Expand Up @@ -444,7 +444,7 @@ void __raise_softirq_irqoff(unsigned int nr)
or_softirq_pending(1UL << nr);
}

void __init open_softirq(int nr, void (*action)(struct softirq_action *))
void __init open_softirq(int nr, void (*action)(void))
{
softirq_vec[nr].action = action;
}
Expand Down Expand Up @@ -486,7 +486,7 @@ void __tasklet_hi_schedule(struct tasklet_struct *t)
}
EXPORT_SYMBOL(__tasklet_hi_schedule);

static __latent_entropy void tasklet_action(struct softirq_action *a)
static __latent_entropy void tasklet_action(void)
{
struct tasklet_struct *list;

Expand Down Expand Up @@ -522,7 +522,7 @@ static __latent_entropy void tasklet_action(struct softirq_action *a)
}
}

static __latent_entropy void tasklet_hi_action(struct softirq_action *a)
static __latent_entropy void tasklet_hi_action(void)
{
struct tasklet_struct *list;

Expand Down
2 changes: 1 addition & 1 deletion kernel/time/timer.c
Expand Up @@ -1624,7 +1624,7 @@ static inline void __run_timers(struct timer_base *base)
/*
* This function runs timers and the timer-tq in bottom half context.
*/
static __latent_entropy void run_timer_softirq(struct softirq_action *h)
static __latent_entropy void run_timer_softirq(void)
{
struct timer_base *base = this_cpu_ptr(&timer_bases[BASE_STD]);

Expand Down
2 changes: 1 addition & 1 deletion lib/irq_poll.c
Expand Up @@ -75,7 +75,7 @@ void irq_poll_complete(struct irq_poll *iop)
}
EXPORT_SYMBOL(irq_poll_complete);

static void __latent_entropy irq_poll_softirq(struct softirq_action *h)
static void __latent_entropy irq_poll_softirq(void)
{
struct list_head *list = this_cpu_ptr(&blk_cpu_iopoll);
int rearm = 0, budget = irq_poll_budget;
Expand Down
4 changes: 2 additions & 2 deletions net/core/dev.c
Expand Up @@ -4095,7 +4095,7 @@ int netif_rx_ni(struct sk_buff *skb)
}
EXPORT_SYMBOL(netif_rx_ni);

static __latent_entropy void net_tx_action(struct softirq_action *h)
static __latent_entropy void net_tx_action(void)
{
struct softnet_data *sd = this_cpu_ptr(&softnet_data);

Expand Down Expand Up @@ -5609,7 +5609,7 @@ static int napi_poll(struct napi_struct *n, struct list_head *repoll)
return work;
}

static __latent_entropy void net_rx_action(struct softirq_action *h)
static __latent_entropy void net_rx_action(void)
{
struct softnet_data *sd = this_cpu_ptr(&softnet_data);
unsigned long time_limit = jiffies +
Expand Down

0 comments on commit 0d054ac

Please sign in to comment.