This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Fix styles breaking transitionend/animationend event #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy-set-studio
suggested changes
Oct 3, 2019
src/reset.css
Outdated
| @@ -67,11 +67,11 @@ select { | |||
| font: inherit; | |||
| } | |||
|
|
|||
| /* Remove _all_ animations and transitions for people that prefer not to see them */ | |||
| /* Remove transitions for people that prefer not to see them */ | |||
| /* Animations should be handled manually */ | |||
There was a problem hiding this comment.
This nuclear approach protects people with are negatively affected by motion. Often devs either aren't aware of this media query or they forget to account for it. With that in mind this line should be removed.
Andy-set-studio
approved these changes
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://codepen.io/atomiks/pen/gOOYGgM
I don't think it's possible to force
animations paused, due to theanimationendevent, and usinganimation-duration: 0.01msinstead (or shorter) creates a weird initial jerk in Firefox, and Chrome/Safari flicker if it's an infinite animation unless the duration is like0.000001ms. Forcing anything there seems unsafe.Fixes #5