Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
chore(Conventions): naming standards #196
| @@ -5,7 +5,7 @@ import {Component} from 'angular2/core'; | ||
| import {RouteConfig, Router, ROUTER_DIRECTIVES} from 'angular2/router'; | ||
| import {FORM_PROVIDERS} from 'angular2/common'; | ||
| -import {Home} from './home/home'; | ||
| +import {HomeCmp} from './home/home.component'; | ||
| /* | ||
| * App Component | ||
| @@ -36,10 +36,10 @@ import {Home} from './home/home'; | ||
| ` | ||
| }) | ||
| @RouteConfig([ | ||
| - { path: '/', component: Home, name: 'Index' }, | ||
| - { path: '/home', component: Home, name: 'Home' } | ||
| + { path: '/', component: HomeCmp, name: 'Index' }, | ||
| + { path: '/home', component: HomeCmp, name: 'Home' } | ||
| ]) | ||
| -export class App { | ||
| +export class AppCmp { | ||
NathanWalker
Contributor
|
||
| name = 'Angular 2 Webpack Starter'; | ||
| url = 'https://twitter.com/AngularClass'; | ||
| constructor() { | ||
| @@ -1,13 +1,13 @@ | ||
| -import {Component} from 'angular2/core'; | ||
| +import {Component, OnInit} from 'angular2/core'; | ||
| import {FORM_DIRECTIVES} from 'angular2/common'; | ||
| import {Http} from 'angular2/http'; | ||
| -import {Title} from './providers/title'; | ||
| -import {XLarge} from './directives/x-large'; | ||
| +import {Title} from '../../providers/title.provider'; | ||
| +import {XLarge} from '../../directives/x-large.directive'; | ||
| @Component({ | ||
| // The selector is what angular internally uses | ||
| - // for `document.querySelectorAll(selector)` in our index.html | ||
| + // for document.querySelectorAll(selector) in our index.html | ||
| // where, in this case, selector is the string 'app' | ||
| selector: 'home', // <home></home> | ||
| // We need to tell Angular's Dependency Injection which providers are in our app. | ||
| @@ -27,7 +27,7 @@ import {XLarge} from './directives/x-large'; | ||
| // Every Angular template is first compiled by the browser before Angular runs it's compiler | ||
| template: require('./home.html') | ||
| }) | ||
| -export class Home { | ||
| +export class HomeCmp implements OnInit { | ||
NathanWalker
Contributor
|
||
| // TypeScript public modifiers | ||
| constructor(public title: Title, public http: Http) { | ||
can you make a separate pull-request for this?