Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

updated readme #205

Merged
merged 6 commits into from Jan 8, 2016

Conversation

Projects
None yet
2 participants
Contributor

samvloeberghs commented Jan 8, 2016

master...samvloeberghs:master#diff-04c6e90faac2675aa89e2176d2eec7d8L49:

When you follow the guide and you install typings globally, you don't need to reference it into node modules, right?

master...samvloeberghs:master#diff-04c6e90faac2675aa89e2176d2eec7d8L54

I just followed you guys setup description and http://0.0.0.0:3000 doesn't work by default on a Windows machine. So I've added http://localhost:3000.

Grtz

Contributor

samvloeberghs commented Jan 8, 2016

I've just spotted the use of 0.0.0.0 in the webpack config files as well.
https://github.com/AngularClass/angular2-webpack-starter/blob/master/webpack.prod.config.js#L19
https://github.com/AngularClass/angular2-webpack-starter/blob/master/webpack.config.js#L18

Is it ok to just use localhost? On a Windows machine, the use of 0.0.0.0 is breaking functionality hard.

Owner

gdi2290 commented Jan 8, 2016

0.0.0.0 was used for virtual machines but we can change it back and I'll just add it to FAQ.

@gdi2290 gdi2290 commented on an outdated diff Jan 8, 2016

README.md
@@ -46,12 +46,12 @@ cd angular2-webpack-starter
npm install
# install TypeScript typings
-./node_modules/.bin/typings install
@gdi2290

gdi2290 Jan 8, 2016

Owner

can you leave this

@gdi2290 gdi2290 commented on the diff Jan 8, 2016

README.md
# start the server
npm start
```
-go to [http://0.0.0.0:3000](http://0.0.0.0:3000) in your browser
+go to [http://0.0.0.0:3000](http://0.0.0.0:3000) or [http://localhost:3000](http://localhost:3000) in your browser
@gdi2290

gdi2290 Jan 8, 2016

Owner

can you also update the webpack.config

Contributor

samvloeberghs commented Jan 8, 2016

done but please validate
(i'll remember to rebase next time)

Owner

gdi2290 commented Jan 8, 2016

thanks!

@gdi2290 gdi2290 added a commit that referenced this pull request Jan 8, 2016

@gdi2290 gdi2290 Merge pull request #205 from samvloeberghs/master
updated readme
7086a67

@gdi2290 gdi2290 merged commit 7086a67 into AngularClass:master Jan 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment