Fix of Firefox's IndexSizeError #70

Merged
merged 1 commit into from Feb 28, 2013

Projects

None yet

2 participants

@Nek
Contributor
Nek commented Feb 25, 2013

No description provided.

@Nek
Contributor
Nek commented Feb 25, 2013

Sorry, no isolated tests for this bug.
It happens in firefox on .drawImage call with empty image (width, height == 0)

@shamansir
Collaborator

If this error has IndexSizeError type, I'd either:

  • Check if catchen error is typeof IndexSizeError and skip it only in this case (because in fact there are a lot of possible errors that we may miss with this code)
  • Or, even better, fire our custom AnimationError for all of the browsers, since why you'd want to use empty image? (or you do?)
@shamansir shamansir merged commit 3cd7bdb into master Feb 28, 2013

1 check passed

default The Travis build passed
Details
@Nek
Contributor
Nek commented Feb 28, 2013

I do. The images are empty before they are loaded but the code which throws the error can access them before the loading is finished.

Nikita

On Thursday, February 28, 2013 at 11:29 PM, Ulric Wilfred wrote:

If this error has IndexSizeError type, I'd either:
Check if catchen error is typeof IndexSizeError and skip it only in this case (because in fact there are a lot of error)
Or, even better, fire it our custom AnimationError for all of the browsers, since why you'd want to use empty image? (or you do?)


Reply to this email directly or view it on GitHub (#70 (comment)).

@mcm69 mcm69 deleted the firefox_indexsize_bug branch Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment