Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Wrapping Up #71

Closed
jayair opened this issue Apr 10, 2017 · 22 comments

Comments

@jayair
Copy link
Member

commented Apr 10, 2017

@jayair jayair added the Discussion label Apr 10, 2017

@badfun

This comment has been minimized.

Copy link

commented May 5, 2017

Hi guys,
I've followed your tutorial through to setting up the endpoints, skimmed ahead on the front-end stuff, and gone through the source code. I don't see anything about Lambda in here at all. Am I missing something?
thanks.

@PatrykTies

This comment has been minimized.

Copy link

commented May 5, 2017

Whole back end api is based on lambdas, this tut using serverless framework to create lambdas. Just spend 1-2 hrs and finish back end part of this tutorial and you will see lambdas in action. This is best tut ever! Thanks guys for making it.

@badfun

This comment has been minimized.

Copy link

commented May 5, 2017

Ah I see. Setting up Administrator Access means we don't have to explicitly setup Lambda access. I didn't deploy but now have so the functions have been created and can see them.
Yes great tutorial Thanks!

@deepseafishing

This comment has been minimized.

Copy link

commented Aug 2, 2017

hey @jayair can u perhaps how i can make this service into mobile app like the picture you show it here? did u have to make the front end all again?

@jayair

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2017

@deepseafishing Oh we didn't really make it into an app here. We just added the web app to our home screen. But since we set the icons properly earlier in the tutorial, it shows up pretty nicely on our home screen.

img_0593-copy

@pjamieson

This comment has been minimized.

Copy link

commented Aug 22, 2017

Great tutorial. Thanks!

For anyone who might be interested, I've refactored the React client to use Redux, with a README.md and the refactored code up at https://github.com/pjamieson/iartx-serverless-client. Comments and suggestions welcome.

@jayair

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2017

@pjamieson That looks pretty good! I'll check it out in detail and share it with the rest of community.

@pjamieson

This comment has been minimized.

Copy link

commented Aug 22, 2017

@triunm

This comment has been minimized.

Copy link

commented Oct 8, 2017

This is the best material to get started w/ serverless in aws. Thank you guys!

@x11joe

This comment has been minimized.

Copy link

commented Nov 11, 2017

Amazing tutorial. The amount of detail that goes into this tutorial is simply amazing. Taking into account all the little things I wanted, like www redirects, cache, scripts to make deploying easy, serverless framework for the api, https, redirecting urls to where you need to go if your session timed out!! (you didn't even have to cover this), but its amazing that you did! Simply the best tutorial I have ever read. In fact so much so, I would like permission to create a set of videos (giving you guys credit of course), to help explain it further given the particular troubles I went through. I have a tutorial video youtube thing I am doing. Let me know if this is okay :).

I became a patron for you guys to help you out also :). Let me know if you ever need help.

I wanted to note that a chapter on SEO is very critical since React renders with javascript the search engines can't find the text on the page. Could you write a chapter on this topic (pretty please :) ), since i think its equally as important as some of the other points that were given.

@jayair

This comment has been minimized.

Copy link
Member Author

commented Nov 13, 2017

@x11joe Thanks for the kind words and support. It means a lot!

I think adding more detail through a video would be very helpful. Especially if you can build on the tutorial and add your perspective. We would love to link to it in the tutorial. I know one of our other readers is also working on a video series. You can take a look at it if you need some ideas or inspiration - #152.

@rtorcato

This comment has been minimized.

Copy link

commented Nov 21, 2017

You guys should have a chapter on costs. This should compare the cost of running this type of infrastructure over running a lamp/lemp type server setup. I know they are not comparable because of scale, but for a small to medium sized site I think the serverless architecture ends up being more expensive.

@jayair

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2017

@rtorcato We do a quick calculation on the cost of running this tutorial app in this chapter here - https://serverless-stack.com/chapters/why-create-serverless-apps.html. For very large sites Serverless can be more expensive but for small to medium it is a lot cheaper. This has been true in our experience and here is some simple analysis on this - https://www.trek10.com/blog/lambda-cost/

@Ajacs

This comment has been minimized.

Copy link

commented Nov 30, 2017

Guys I get this message when I try to login : UnexpectedParameter : Unexpected key 'UserContextData' found in params, any idea ?

This is the version of libraries:

"amazon-cognito-identity-js": "^1.27.0",
"aws-sdk": "^2.157.0"
@jayair

This comment has been minimized.

Copy link
Member Author

commented Dec 2, 2017

@Ajacs Which step of the tutorial is causing this issue for you?

@SpencerGreene

This comment has been minimized.

Copy link

commented Dec 16, 2017

I will second and third the comments here - a great tutorial, well written and thorough.

If you were going to add anything else, I'd suggest a "forgot password" chapter, since that would show how to send the user an email. And a +1 on the SEO comment above!

@iggiFW

This comment has been minimized.

Copy link

commented Apr 4, 2018

I didn't run any tests during this tutorial, and by the end of it, the standard create-react-app tests are broken for me. Running "npm test" yields:

> notes-app-client@0.1.0 test /Users/Bazo/serverlessReact/notes-app-client
> react-scripts test --env=jsdom

2018-04-04 15:24 node[65744] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2018-04-04 15:24 node[65744] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2018-04-04 15:24 node[65744] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at exports._errnoException (util.js:1036:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1406:11)
npm ERR! Test failed.  See above for more details.

On the Jest and Facebook GH issues they suggest changing the npm command from

    "test": "react-scripts test --env=jsdom",

to

    "test": "jest",

which then yields a different error:

npm test                                                                                                         ⏎

> notes-app-client@0.1.0 test /Users/Bazo/Desktop/projekkz/serverlessReact/notes-app-client
> jest

 FAIL  src/App.test.js
  ● Test suite failed to run

    /Users/Bazo/Desktop/projekkz/serverlessReact/notes-app-client/src/App.test.js: Unexpected token (7:18)
         5 | it('renders without crashing', () => {
         6 |   const div = document.createElement('div');
      >  7 |   ReactDOM.render(<App />, div);
           |                   ^
         8 |   ReactDOM.unmountComponentAtNode(div);
         9 | });
        10 |

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        1.357s
Ran all test suites.
npm ERR! Test failed.  See above for more details.

It seems to be a problem with babel maybe? It has a problem with the JSX caret symbol. When I run a brand new create-react-app and run 'npm test', tests work fine. I'm using latest npm. I've tried deleting node_modules, package.json.lock and reinstalling them, but the problem is still there. Anyone else having this issue? (Great tutorial by the way, I think adding one test at the end to show that tests work would make it stronger).

@jayair

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2018

@iggiFW I'm seeing a different error on my end but yeah tests are something we'll add at some point. I'm not entirely sure why you are seeing a JSX related error.

@miloofcroton

This comment has been minimized.

Copy link

commented Apr 6, 2018

Hey, just wanted you guys to know that the https://serverless-stack.com/#tools link is no longer pointing to any section on the homepage. No mas tools section.

@jayair

This comment has been minimized.

Copy link
Member Author

commented Apr 6, 2018

@miloofcroton Good catch. Fixed it. Thanks.

@iggiFW

This comment has been minimized.

Copy link

commented Apr 9, 2018

@jayair ok I'll open an issue on the tests failing. I'll try to go back through my commit history and figure out what step in the tutorial broke the tests and report back on that.

@jayair

This comment has been minimized.

Copy link
Member Author

commented May 9, 2018

@jayair jayair closed this May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.