Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/tarsnap-backup: ShellCheck #1

Merged
merged 1 commit into from Sep 11, 2016
Merged

bin/tarsnap-backup: ShellCheck #1

merged 1 commit into from Sep 11, 2016

Conversation

jlduran
Copy link

@jlduran jlduran commented Sep 5, 2016

Apply ShellCheck recommendations:

  • Double quote variables to prevent globbing and word splitting
  • Use $(..) instead of legacy ..
  • expr is antiquated. Rewrite using $((..))
  • Fix if [ -n something_wrong ];

@AnotherKamila
Copy link
Owner

LGTM, but currently I cannot test this (AFK for about a week). Have you tried running the fixed script, just in case?

Thanks!

@jlduran
Copy link
Author

jlduran commented Sep 11, 2016

Yes, it runs on a server everyday (installed as a package)... thank you!

@AnotherKamila
Copy link
Owner

Awesome, thanks.

@AnotherKamila AnotherKamila merged commit 16f5580 into AnotherKamila:master Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants