Fix+docs for background tasks when used by FtResponse

[pydanny]

---

name: Pull Request
about: Propose changes to the codebase
title: '[PR] Correct background tasks when used by FtResponse'
labels: 'bug'
assignees: ''

---

Related Issue

#336 - Background Tasks

Proposed Changes

This PR makes it possible for the FtResponse class to handle Background Tasks

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

[gitnotebooks]

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/674

[jph00]

I think self.background will always be set, so I'm not sure this is doing anything? Also IIUC it's the wrong way around - we should use the manually added tasks in the response if there, and only then fall back to self.background, shouldn't we?

Either way, it's a good idea to have tests or examples that exercise your code so that you know for sure whether it's working.

[pydanny]

Thanks for the feedback, we'll adjust the API accordingly and see about improving/adding to the tests and docs.

[pydanny]

Got the order of operations corrected, tasks now go for manual before self.background. Thanks @RensDimmendaal for the assist.

[jph00]

Let me know when it's ready for review @pydanny (no hurry though)

[pydanny]

This is ready for review.

[hamelsmu]

@pydanny This is a really well written tutorial. I love how you use code annotations for the docs with Quarto- extra love. Made it really easy to read and also learn about how it works.

[hamelsmu]

@jph00 do you want to do a review or is this ok to merge? I find this feature to be very valuable in most things that I end up building.

[hamelsmu]

Edit:

Q: Can we ship this now?
A: Yes.

Merging