From dd875eec9bcfe99b698b6b6549a9010429f8ac12 Mon Sep 17 00:00:00 2001 From: Florian OMNES <26088210+flomnes@users.noreply.github.com> Date: Tue, 16 Jan 2024 10:23:01 +0100 Subject: [PATCH] Fix incorrect return value, use exit code instead of stdout --- scripts/antares_test_utils.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/antares_test_utils.py b/scripts/antares_test_utils.py index 7de5683..5f038b7 100644 --- a/scripts/antares_test_utils.py +++ b/scripts/antares_test_utils.py @@ -64,9 +64,10 @@ def launch_solver(solver_path, study_path, use_ortools = False, ortools_solver = command.append('--named-mps-problems') process = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=None) - output = process.communicate() + stdout, stderr = subprocess.communicate() + exit_code = subprocess.wait() - return "Solver returned error" not in output[0].decode('iso-8859-1') + return (exit_code == 0) def generate_reference_values(solver_path, path, use_ortools, ortools_solver, named_mps_problems):