Skip to content

[2.0.0-dev] remove 'count' from get_table_by_scope response #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/2.0
Choose a base branch
from
Open

[2.0.0-dev] remove 'count' from get_table_by_scope response #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/chain_plugin/chain_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1651,7 +1651,7 @@ read_only::get_table_by_scope_result read_only::get_table_by_scope( const read_o
for( unsigned int count = 0; count < limit && itr != end_itr; ++itr, ++count ) {
if( p.table && itr->table != p.table ) continue;

result.rows.push_back( {itr->code, itr->scope, itr->table, itr->payer, itr->count} );
result.rows.push_back( {itr->code, itr->scope, itr->table, itr->payer} );

if (fc::time_point::now() >= params_deadline)
break;
Expand Down
3 changes: 1 addition & 2 deletions plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,6 @@ class read_only : public api_base {
name scope;
name table;
name payer;
uint32_t count = 0;
};
struct get_table_by_scope_result {
vector<get_table_by_scope_result_row> rows;
Expand Down Expand Up @@ -1037,7 +1036,7 @@ FC_REFLECT( eosio::chain_apis::read_only::get_table_rows_params, (json)(code)(sc
FC_REFLECT( eosio::chain_apis::read_only::get_table_rows_result, (rows)(more)(next_key) );

FC_REFLECT( eosio::chain_apis::read_only::get_table_by_scope_params, (code)(table)(lower_bound)(upper_bound)(limit)(reverse)(time_limit_ms) )
FC_REFLECT( eosio::chain_apis::read_only::get_table_by_scope_result_row, (code)(scope)(table)(payer)(count));
FC_REFLECT( eosio::chain_apis::read_only::get_table_by_scope_result_row, (code)(scope)(table)(payer));
FC_REFLECT( eosio::chain_apis::read_only::get_table_by_scope_result, (rows)(more) );

FC_REFLECT( eosio::chain_apis::read_only::get_currency_balance_params, (code)(account)(symbol));
Expand Down
1 change: 0 additions & 1 deletion tests/get_table_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ BOOST_FIXTURE_TEST_CASE( get_scope_test, validating_tester ) try {
BOOST_REQUIRE_EQUAL(name("inita"_n), result.rows[0].scope);
BOOST_REQUIRE_EQUAL(name("accounts"_n), result.rows[0].table);
BOOST_REQUIRE_EQUAL(name("eosio"_n), result.rows[0].payer);
BOOST_REQUIRE_EQUAL(1u, result.rows[0].count);

BOOST_REQUIRE_EQUAL(name("initb"_n), result.rows[1].scope);
BOOST_REQUIRE_EQUAL(name("initc"_n), result.rows[2].scope);
Expand Down