Reverse queue lock icons

[anarcat]

App version: 1.5.2.0

Android version: 5.1/CM 12.1?

Devide model: HTC One S

This is just usability nit-picking, but I always get confused by the "lock" icon in the

This is the queue, unlocked:

Notice how the padlock button on top is in the "locked" position. This is weird to me: it gives me the impression that the queue is locked!

This is what happens when I click it:

Now the queue is locked and the button shows and unlocked padlock button.

Is this by design?

Sorry for the stupid question.

[anarcat]

Oh, and I forgot to mention, obviously: you guys rock. This is the best podcasting application I have ever seen, congratulations on basically ruling the world.

Thanks.

[keunes]

Yup, that's by design. It was changed not too long ago since a button should (1) display what it does (not what is) i.e.: "Go lock the queue!" (and vice-versa)

(1) EDIT: as in I think it should, not referring to guidelines - if there are any

[mfietz]

Guidelines are meant to be broken, especially if they are as stupid as Google's ones are from time to time.
For example, as soon as you push any of the refresh buttons, they turn from showing the action to showing the current status (in progress). Fav/unfav is also reversed...

[anarcat]

well, that confuses the hell out of me. I have no idea about google or guidelines or anything like that, i'm coming at this purely from a user perspective. :)

"sleep" has a similar issue, but i can see more where that one is coming from...

[keunes]

To me, also from a user perspective, current use is more logic than the reverse (I got confused when before current behaviour was implemented) :P (I'm saying this without having checked if there actually are any google guidelines; my 'should' was referring to my personal opinion)

FYI: The current design was introduced in #1523.

[mfietz]

@TomHennen Opinion? I'm in favor of the lock icon showing state

[keunes]

(makes me wonder why the PR was merged 3 months ago, talking of 'consistency' :P )

[mfietz]

Because sometimes I just get tired from all these discussions really leading nowhere and just agree :p

[anarcat]

Sorry for the trouble folks, i did look through the issue queue for such an issue and didn't find any. If I would have found that other PR, i would have probably not opened this issue and I am tempted to close it now. It's really a cosmetic change, and we can get used to it i guess.

[ByteHamster]

I do not think there is a clear answer to this request. Any way we do it, some users will not be happy. I would prefer to keep it as it currently is because it has been that way for the last 3 years and the change was not requested by more users.