Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some episodes appear twice in feed #3275

Closed
janitz opened this issue Jul 16, 2019 · 35 comments · Fixed by #4839
Closed

Some episodes appear twice in feed #3275

janitz opened this issue Jul 16, 2019 · 35 comments · Fixed by #4839
Assignees
Labels
Type: Confirmed bug Bugs confirmed by a lead developer

Comments

@janitz
Copy link

janitz commented Jul 16, 2019

App version: 1.7.2b from Google Play

Android version: 8.0.0

Device model: LG-H870 (G6)

Expected behaviour:
every episode appears once in feed

Current behaviour:
some episodes in some feeds appear twice and get downloaded twice with auto download

First occurred: not sure... Maybe weeks ago

Environment: Auto Download

Examples:
http://podcast.djhardwell.com/podcast.xml

Screenshot_2019-07-16-06-31-55
Screenshot_2019-07-16-06-31-25

http://www.deutschlandfunk.de/podcast-der-politik-podcast.3292.de.podcast.xml
Screenshot_2019-07-16-06-47-33

@egvimo
Copy link

egvimo commented Jul 16, 2019

I had the same problem (several times). It helped me to remove the podcast and subscribe again.

@keunes
Copy link
Member

keunes commented Jul 20, 2019

@janitz Did the suggestion (delete and re-add the podcast) solve your issue?

@janitz
Copy link
Author

janitz commented Jul 21, 2019

Yes it removed the doubled episodes. But it also removes the played status of all episodes of the feed.

@keunes
Copy link
Member

keunes commented Jul 21, 2019

Annoying but logical. If you've replaced both feeds, you can probably close this issue. If you still have one feed with duplication you might keep it open in case there's someone able to find the root cause.

@ByteHamster
Copy link
Member

ByteHamster commented Jul 21, 2019

This usually happens if the creator changes the id of an episode. I can look at a database export if you want help find the cause. If you do not want to share it publicly, you can also send me an email to info@<my GitHub username>.com

@janitz
Copy link
Author

janitz commented Jul 21, 2019

I sent you an email with my database export.

@ByteHamster
Copy link
Member

I have looked at the database. Looks like AntennaPod added 424,113,424,113 directly after each other. My guess that the publisher changed the ID was wrong. The items are exactly the same in the database. It definitely is a bug but I currently have no idea what could cause it. AntennaPod already looks at the database and verifies that the ID is new. Theoretically, this should not happen.

@ByteHamster ByteHamster added the Type: Confirmed bug Bugs confirmed by a lead developer label Jul 21, 2019
@jakern
Copy link

jakern commented Jul 28, 2019

Since you have no other leads I just wanted to chime in and say I had a similar issue that was caused by the publisher removing and re-uploading the episode.

@linuxhelper
Copy link

I've been having this issue for a few weeks as well. Antennapod has also been ignoring when I delete a downloaded episode and I'm forced to resume it after my current podcast is finished.

@oznogon
Copy link

oznogon commented Aug 8, 2019

I have this issue with several iTunes podcasts, and the episodes are not being removed and republished. If I manually modify the status or cancel the download one of the duplicate episode entries, it affects both entries at once. But if I listen to one, it does not automatically change the "listened" state on both.

After removing the podcast and re-adding it, every episode appears only once as expected. Any new episodes published after that appear twice.

1.7.2b commit b892713, via FDroid, Nokia 6.1, Android 9

@phene
Copy link

phene commented Aug 15, 2019

I'm running into an issue with duplicate episodes, as well. Removing and re-adding the feeds has not fixed it. Also on version 1.7.2b commit b892713

@ByteHamster
Copy link
Member

@phene Could you please post the feed url that has duplicates even if you removed and re-added? You can find the url behind the info icon on the feed details screen.

@Tacoma
Copy link

Tacoma commented Sep 27, 2019

I have a similar problem with this feed: http://einschlafen-podcast.de/feed/mp3/
Except that almost every episode is duplicated a few days after adding the podcast. Version 1.7.3, Android 9. Happened already a few weeks ago on a different phone, I just readded the podcast, hoping it won't happen again.

@ByteHamster
Copy link
Member

Just to gather some more data: do you use gpodder sync?

@Tacoma
Copy link

Tacoma commented Sep 27, 2019

@ByteHamster If you mean Integration->gpodder.net, no.

@mavosaure
Copy link

I experimented same problem on some feeds, and have no gpodder or other sync account.
Data is stored on my SD card. Is it possible that following symbolic link AntennaPod reads two times the same library?

@nZambi-
Copy link

nZambi- commented Nov 30, 2019

Hey all. First, Thank you.
Just wanted to add here and give this issue a bump. I have been having trouble with duplicate Downloads for a few months now. I have deleted and re-added my subscriptions with no improvement. I Then deleted AntennaPod completely and reinstalled. It is happening again.
This happens with multiple podcasts. Feed URL seems to be identical. Sometimes a few days later but at least once the dupe was downloaded immediately after the first.
I use auto download on per-podcast basis.
I Used to simply remove the Dupes manually, but this is starting to feel like too much extra / unnecessary work for me. Any help would be appreciated.

@nZambi-
Copy link

nZambi- commented Dec 14, 2019

Just one more try here. I have deleted the android app and all data (as far as I can tell) and reinstalled keeping all settings factory-stock. version 1.7.3b Commit f9e7e9a .
I subscribed to 5 podcasts and allowed automatic Downloads. 4 of the subscribed podcasts are now adding Dupes... looking at the log, the media file is the same and sometimes the dupe is DLed within minutes of the first. I have checked with the 3 people I know who are using antennaPod at my suggestion and two of them are experiencing the same issue.
I can no longer keep managing the dupes manually so I'll move on to another app while keeping one eye on this one.
Thanks and Good Luck to the developers.

@oznogon
Copy link

oznogon commented Dec 14, 2019

Still affects 1.7.3c commit dc07308 from F-Droid, with no change in behavior from my previous comment

@aweb777
Copy link

aweb777 commented Dec 31, 2019

Here 2, 31.12.2019

@icf20
Copy link

icf20 commented Feb 9, 2020

i am getting startalk 4 times removed everything and now i get 3 times

@tonytamsf
Copy link
Member

could people who are receiving dups ping at least one feed url? I think the app used the guid for duplication detection, maybe it needs to hash the subscription url+title as well?

@ByteHamster
Copy link
Member

ByteHamster commented Feb 10, 2020

Publishers regularly mess up the guids. I think when searching for existing items, we should first look for an item with the same guid. If we do not find one, look for an item with the same download url AND same title. If we still do not find an item, it is probably new.

We should keep in mind that there are feeds without media. Theoretically, there might even be feeds which use the same media file for different items.

@phene
Copy link

phene commented Feb 10, 2020

I just got this bug to go away when I changed the Update Interval to once a day instead of every 4 hours.

@tonytamsf
Copy link
Member

Publishers regularly mess up the guids. I think when searching for existing items, we should first look for an item with the same guid. If we do not find one, look for an item with the same download url AND same title. If we still do not find an item, it is probably new.

We should keep in mind that there are feeds without media. Theoretically, there might even be feeds which use the same media file for different items.

I have a fix here #4839 which should be able to handle GUID de-duplication pretty well. I don't think we should be too much more ambitious to deduplicate feeds and just honor getIdentifyingValue() which handles GUID, title and media

@tonytamsf
Copy link
Member

@keunes can you assign to me?

@tonytamsf
Copy link
Member

If anyone is still seeing duplicate feed items, please ping the name of the podcast or a RSS URL

@javissimo
Copy link

If anyone is still seeing duplicate feed items, please ping the name of the podcast or a RSS URL

https://www.primaverasound.com/radio/shows/deforme-semanal-ideal-total?action=rss I'm getting each episode twice (I'm also synced with gpodder)

@tonytamsf
Copy link
Member

https://www.primaverasound.com/radio/shows/deforme-semanal-ideal-total?action=rss

@javissimo What was the title of the episode or are you saying you are getting every episode twice? This sounds like an issue with gpodder syncing. But I think my PR here could address that duplication as well, but unfortunately it might hide the real cause of the problem. #4839

@alexanderadam
Copy link

I experimented same problem on some feeds, and have no gpodder or other sync account.

I wasn't aware that the URL change issue also happens without gpodder.
Would that mean that a bugfix for this would also fix issue 2214 if AntennaPod remembers which URL is a duplicate/legacy of which podcast? 🤔

@ByteHamster
Copy link
Member

Episodes appearing twice is not related to gpodder. Gpodder only adds/removes subscriptions.

In all cases of duplicate episodes that I have experienced myself, the podcast hosts messed up the IDs in their feed. I have received one database export where I'm not sure because the ID was the same. Maybe in that case, the host actually added the same episode with the same ID to the feed twice.

If they mess up the IDs, we could do some amount of guessing if they still mean an old episode. This has to be done very carefully though, to not violate the standard ourselves just because we try to work around publishers violating it.

@itmike
Copy link

itmike commented Jun 14, 2021

Here's one more pod with this issue, on some episodes:
http://api.sr.se/api/rss/pod/4007

I reported it to the publisher, but they belive they are managing guid correctly.

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/duplicates/1054/2

@tonytamsf
Copy link
Member

Will be shipped in version 2.4 #4839

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/resolving-episode-duplication-issue-in-antennapod-after-episode-changes/4033/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Confirmed bug Bugs confirmed by a lead developer
Projects
None yet
Development

Successfully merging a pull request may close this issue.