Download failure notification is not removed after subsequent download success

[orionlee]

App version: 1.7.3b

Current behaviour: After some download fails and a failure notification is generated [*], if the downloads are complete later on (e.g., users tap to download again), the failure notification remains there.

Expected behaviour: when downloads are complete, the app removes any existing download failure notification.

Note: Users are more likely to encounter the scenario with PR #2714, as one of its side-effect is it will automatically retry the failed media downloads.

The scenario would be:

1. Episode automatic download kicks in
2. Some downloads fail, e.g., due to poor internet connection
3. The failed downloads are soon retried (side effect of PR Enqueue fixes: 1) option to enqueue after currently playing 2) respect download start order #2714). They are successful at the end.

Later, when the user turns on the screen,

• the user would see a (misleading) download failure notification, generated in step 2 above

Environment: applicable when "Show Download Report" is enabled.

---

[*] Screenshot

[ByteHamster]

The failed downloads are soon retried (side effect of PR #2714). They are successful at the end.

What does this mean? Are they retried automatically?

[orionlee]

The failed downloads are retried automatically as a side effect of PR #2714.
The sequence of events is as follows:

1. episode is first automatically enqueued before download begins (PR Enqueue fixes: 1) option to enqueue after currently playing 2) respect download start order #2714 )
2. download fails, the episode remains in the queue
3. when auto download is triggered again [*], it will try to download the episode again (because it is in the queue), effectively retrying the download.

In existing v1.7.3b release (without PR #2714 ), similar situation could arise in a slightly different (probably less likely) sequence:

1. the user enqueues an episode to the queue (without download)
2. the user later taps to download the episode
3. If the download fails, it would be in the same situation.

---

[*] Auto download would get triggered again due to a few possible reasons, e.g., when download completes, when network is available, etc.

[ByteHamster]

Just throwing in some questions that came to my mind. Do we actually want this to happen? I think retrying should be done by the download service. Can this lead to indefinite loops with unusual settings configurations? What if the first episode in the queue simply can't be downloaded? This might prevent other downloads.

[ByteHamster]

To implement that feature, we would either need to dismiss the notification each time the DownloadService is finished (we do not want to do that because users might miss the error message when starting downloads manually) or store the contents of the posted notification somewhere on the disk. I do not think this feature is so important that it is worth storing posted notification contents on the disk. Sorry.