-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download failure notification is not removed after subsequent download success #3594
Comments
What does this mean? Are they retried automatically? |
The failed downloads are retried automatically as a side effect of PR #2714.
In existing
[*] Auto download would get triggered again due to a few possible reasons, e.g., when download completes, when network is available, etc. |
Just throwing in some questions that came to my mind. Do we actually want this to happen? I think retrying should be done by the download service. Can this lead to indefinite loops with unusual settings configurations? What if the first episode in the queue simply can't be downloaded? This might prevent other downloads. |
To implement that feature, we would either need to dismiss the notification each time the DownloadService is finished (we do not want to do that because users might miss the error message when starting downloads manually) or store the contents of the posted notification somewhere on the disk. I do not think this feature is so important that it is worth storing posted notification contents on the disk. Sorry. |
App version: 1.7.3b
Current behaviour: After some download fails and a failure notification is generated [*], if the downloads are complete later on (e.g., users tap to download again), the failure notification remains there.
Expected behaviour: when downloads are complete, the app removes any existing download failure notification.
Note: Users are more likely to encounter the scenario with PR #2714, as one of its side-effect is it will automatically retry the failed media downloads.
The scenario would be:
Later, when the user turns on the screen,
Environment: applicable when "Show Download Report" is enabled.
[*] Screenshot
The text was updated successfully, but these errors were encountered: