Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcast title containing decimal codes for quotation marks display incorrectly #4789

Closed
GregoryHuff opened this issue Dec 23, 2020 · 8 comments
Labels
Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet

Comments

@GregoryHuff
Copy link

Checklist

  • [x ] I have used the search function to see if someone else has already submitted the same bug report.
  • [x ] I will describe the problem with as much detail as possible.
  • [x ] If the bug only to occurs with a certain podcast, I will include the URL of that podcast.

System info

App version: 2.1.1

App source: F-Droid

Android version: 10

Device model: SM-G960F

Bug description

Steps to reproduce:

  1. Strangely, this is only a bug for one password protected RSS feed I subscribe to. There's a free version which doesn't have this problem. The protected one has a title containing “ and ” which should display quotes but instead just display these codes.
  2. The RSS feed contains <title>&#8220;YOUR WELCOME&#8221;</title>
@GregoryHuff GregoryHuff added the Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet label Dec 23, 2020
@ByteHamster
Copy link
Member

This usually happens if the creators of the feed encode the symbols twice. Try downloading the feed file and viewing it in a text editor. AntennaPod can handle &#8220; but if the creators write &amp;#8220;, they are explicitly telling AntennaPod to display the code. If that's the case, it would be good to contact them about that.

@nicolaus-hee
Copy link

nicolaus-hee commented Jan 9, 2021

I have a similar behavior but it's for the &amp; symbol. Screenshot & url of XML below (not sure which tag you parse). In podcast search results, it is displayed correctly, in the episode list and subscription screen, it is not and weirdly showing &amp; as a string.

XML
URL: https://feeds.lagedernation.org/feeds/ldn-mp3.xml
image

Search results:
Screenshot_20210109-103553

Subscription screen:
Screenshot_20210109-103533

Episode list:
Screenshot_20210109-104629

@ByteHamster
Copy link
Member

@nicolaus-hee AntennaPod looks at itunes:author:

<itunes:author>Philip Banse &amp;amp; Ulf Buermeyer</itunes:author>

@nicolaus-hee
Copy link

nicolaus-hee commented Jan 9, 2021

@ByteHamster Oh, so are you seeing &amp;amp; on your end? I only get &amp;.

<itunes:name>Philip Banse &amp; Ulf Buermeyer</itunes:name>

@ByteHamster
Copy link
Member

Try downloading the file. Browsers already parse one of the entities.

@nicolaus-hee
Copy link

Yeah, noticed. I curled it and still only got one &amp;:

image

@ByteHamster
Copy link
Member

Oh, I see. The broken one is the one inside an <item>. Because itunes:author is only specified for the whole channel and not for individual items, AntennaPod always uses the last itunes:author tag that it finds, regardless where it is.

@ByteHamster
Copy link
Member

Since #4887, we work around publishers double-encoding their names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet
Projects
None yet
Development

No branches or pull requests

3 participants