Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feed update interval or time dialog #5108

Merged
merged 1 commit into from Apr 23, 2021

Conversation

peakvalleytech
Copy link
Contributor

@peakvalleytech peakvalleytech commented Apr 11, 2021

I think i've included everything that you've requested. The tests have been updated and are passing. I think we are missing tests for setting the time, but that can be done in another PR.
Please check it out.

Closes #4708

Copy link
Member

@ByteHamster ByteHamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I added some comments again :) This dialog is so much easier to use than the old one. Really looking forward to merging it :)

peakvalleytech added a commit to peakvalleytech/AntennaPod that referenced this pull request Apr 16, 2021
@ByteHamster
Copy link
Member

I just pushed a few cleanup changes that reduce the number of source code lines significantly :)

@ByteHamster ByteHamster changed the title Interval or time New feed update interval or time dialog Apr 18, 2021
Copy link
Contributor Author

@peakvalleytech peakvalleytech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a few cleanup changes that reduce the number of source code lines significantly :)

So you approve of the PR?

Co-authored-by: Fivel Rangel <fivel10@hotmail.com>
Co-authored-by: ByteHamster <info@bytehamster.com>
@ByteHamster ByteHamster merged commit 7b5f29e into AntennaPod:develop Apr 23, 2021
@ByteHamster
Copy link
Member

Thanks! Will be released in 2.3.0

@FivelMttz I changed the authors of the commit so that it shows all 3 persons who have worked on it together :)

image

@antennapod-bot
Copy link

This pull request has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/antennapod-2-3-0-release-notes/1047/1

@peakvalleytech peakvalleytech deleted the IntervalOrTime branch August 22, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make update time setting easier to use
3 participants