New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feed update interval or time dialog #5108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I added some comments again :) This dialog is so much easier to use than the old one. Really looking forward to merging it :)
app/src/androidTest/java/de/test/antennapod/ui/PreferencesTest.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/fragment/ItemFragment.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/danoeh/antennapod/core/preferences/UserPreferences.java
Outdated
Show resolved
Hide resolved
core/src/main/java/de/danoeh/antennapod/core/service/FeedUpdateWorker.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/dialog/FeedRefreshIntervalDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/dialog/FeedRefreshIntervalDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/dialog/FeedRefreshIntervalDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/dialog/FeedRefreshIntervalDialog.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/dialog/FeedRefreshIntervalDialog.java
Outdated
Show resolved
Hide resolved
3e19c0b
to
37b9e6e
Compare
I just pushed a few cleanup changes that reduce the number of source code lines significantly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a few cleanup changes that reduce the number of source code lines significantly :)
So you approve of the PR?
core/src/main/java/de/danoeh/antennapod/core/preferences/UserPreferences.java
Outdated
Show resolved
Hide resolved
app/src/main/java/de/danoeh/antennapod/dialog/FeedRefreshIntervalDialog.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Fivel Rangel <fivel10@hotmail.com> Co-authored-by: ByteHamster <info@bytehamster.com>
14c47be
to
04ff51b
Compare
Thanks! Will be released in 2.3.0 @FivelMttz I changed the authors of the commit so that it shows all 3 persons who have worked on it together :) |
This pull request has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/antennapod-2-3-0-release-notes/1047/1 |
I think i've included everything that you've requested. The tests have been updated and are passing. I think we are missing tests for setting the time, but that can be done in another PR.
Please check it out.
Closes #4708