New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making the "(i) Filtered" more visible. Fixing issue #5123 #5170
Conversation
@@ -470,7 +470,7 @@ private void refreshHeaderView() { | |||
if (feed.getItemFilter() != null) { | |||
FeedItemFilter filter = feed.getItemFilter(); | |||
if (filter.getValues().length > 0) { | |||
txtvInformation.setText("{md-info-outline} " + this.getString(R.string.filtered_label)); | |||
txtvInformation.setText("{md-info} " + this.getString(R.string.filtered_label)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? Modern apps currently tend to use outline versions of icons.
@@ -126,6 +126,8 @@ | |||
android:background="?android:attr/windowBackground" | |||
android:visibility="gone" | |||
android:gravity="center" | |||
android:textColor="@color/accent_dark" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not change the "filtered" text that the issue was about, but the "updates disabled" text. For my taste, making the font size bigger is a bit too much - it is pretty distracting to users who actually know that they want to filter.
Also, please use ?attr/colorAccent
. Otherwise, it will always use the accent color of the dark theme, which does not have a good contrast in the light theme.
The PR still changes the color of the "updates disabled" message, not the one of the "filtered" message. Maybe we can make both of them blue @keunes? |
But currently when we make the changes and run the app, the "Filtered" text is blue. (@Mchoi8) |
This reverts commit 5a6c845.
Looks like you did not push the changes, then. The code here on GitHub still only change the "updates disabled" text color (see the id of the xml element on the "Files" tab). (again, I think changing both could also work if you want. The current state just does not fix the issue.) |
Thanks. Will be released in AntennaPod 2.3.0 |
This pull request has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/antennapod-2-3-0-release-notes/1047/1 |
This pull request fixes #5123 . The new changes make the filtered word more visible. Fixed the issue with @Mchoi8
Also (@Mengshi24 & @gregoryjtom)