Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore itunes:author when not child of channel #5777

Merged
merged 1 commit into from Mar 13, 2022

Conversation

ByteHamster
Copy link
Member

Closes #5775

@dllmr
Copy link
Contributor

dllmr commented Mar 12, 2022

This doesn't seem to resolve the issue. For the podcast in question (Nomad Podcast) the feed author is not set at all with this change.

EDIT: this is because state.getTagstack().lastElement().getName() evaluates to "author" rather than "channel" for the relevant element.

A suitable alternative might be: -

if (AUTHOR.equals(localName) && state.getFeed() != null && state.getTagstack().size() <= 3) { state.getFeed().setAuthor(contentFromHtml);

Co-authored-by: dllmr <dllmr@users.noreply.github.com>
@ByteHamster
Copy link
Member Author

Thanks for the suggestion @dllmr

@ByteHamster ByteHamster merged commit 197a0a1 into AntennaPod:develop Mar 13, 2022
@ByteHamster ByteHamster deleted the ignore-item-author branch March 13, 2022 10:21
@ByteHamster
Copy link
Member Author

Will be released in 2.6.0

@antennapod-bot
Copy link

This pull request has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/antennapod-2-6-release-notes/1964/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

itunes:author value on item elements overrides same value on channel when setting feed description
3 participants