Skip to content
Commits on Mar 23, 2016
  1. @jeremy

    Merge pull request #24037 from jeremy/implicit-render-raises-on-brows…

    …er-GET-requests-only
    
    Are you missing that template or did you omit it on purpose?
    jeremy committed Mar 23, 2016
  2. @jeremy

    Merge pull request #24259 from jeremy/cable/disconnected-client-errors

    Cable: Gracefully handle disconnected clients
    jeremy committed Mar 23, 2016
  3. @jeremy

    Merge pull request #24167 from kamipo/append_sql_mode_instead_of_over…

    …writing_in_strict_mode
    
    Append sql_mode instead of overwriting in strict mode
    jeremy committed Mar 23, 2016
  4. @rafaelfranca

    Merge pull request #24284 from olivierlacan/patch-1

    Remove reference to unmaintained plugin/gem in Security guide
    rafaelfranca committed Mar 23, 2016
  5. @kaspth

    Merge pull request #24196 from koenpunt/plugin-action-cable

    Bugfix: ActionCable not loaded when generating plugin without ActiveRecord
    kaspth committed Mar 23, 2016
  6. @koenpunt

    Add ActionCable require statement to plugin

    When generating a plugin without ActiveRecord (-O),
    ActionCable wasn't include, which causes problems with the
    require action_cable statement in cable.js
    
    add active_job require statement
    
    also updated order of require statements to match with all.rb
    koenpunt committed Mar 14, 2016
  7. @olivierlacan

    Remove reference to unmaintained plugin/gem

    [restful-authentication](https://rubygems.org/gems/restful-authentication/versions/1.2.1) hasn't been updated since 
    September 6th, 2012 so it might not be a great idea to recommend that Rails users try it out.
    
    Devise seems like a much more popular and secure solution that automatically resets sessions on sign in and out 
    so it's a great example in this case. 
    
    /cc @tenderlove @josevalim
    olivierlacan committed Mar 23, 2016
Commits on Mar 22, 2016
  1. @kaspth

    [ci skip] Improve comment minitest plugin initialization.

    Didn't feel we were clear enough about our motivation for placing Rails first
    and why we needed to call `load_plugins`.
    kaspth committed Mar 22, 2016
  2. @kaspth

    Don't get ahead of ourselves.

    The useless explicit self calls were driving me nuts.
    kaspth committed Mar 22, 2016
  3. @kaspth

    Set Rails as the first minitest initialized plugin.

    When calling `load_plugins` minitest would fill out its extensions, then
    we'd tackle ourselves on as the last plugin. Because minitest loads plugins
    in order we will ultimately have the last say on what reporters will be used.
    
    Invert that strategy by putting ourselves first and give other plugins plenty
    of leeway to override our default reporter setup.
    
    Fixes #24179.
    kaspth committed Mar 22, 2016
  4. @rafaelfranca

    Merge pull request #24278 from keram/rails_code_convention

    Use || instead of `or` in bin/(update|setup) tpl as preferred by rails code convention
    rafaelfranca committed Mar 22, 2016
  5. @keram
  6. @kaspth

    Merge pull request #24276 from artfuldodger/patch-2

    Fix WebSocket already open log message typo
    kaspth committed Mar 22, 2016
  7. @kaspth

    Merge pull request #24275 from arekf/master

    Fix typo for redirect_back (docs)
    kaspth committed Mar 22, 2016
  8. @artfuldodger
  9. @arekf

    Fix typo for redirect_back

    indetical -> identical
    [skip ci]
    arekf committed Mar 22, 2016
  10. @senny

    Merge pull request #24271 from vipulnsward/grammar-fix-changelog

    Fixed abrupt start of sentence in changelog [ci skip]
    senny committed Mar 22, 2016
  11. @vipulnsward

    - Fixed abrupt start of sentence in changelog

    [ci skip]
    vipulnsward committed Mar 22, 2016
  12. @senny

    guides, sync 5.0 release notes with changelogs

    [ci skip]
    
    Sync AV, AR, AJ, AS, AM changelogs with our 5.0 release notes draft.
    This is a follow up to c94045d and contains changes made since the
    release of beta1.
    senny committed Mar 22, 2016
  13. @senny

    guides, sync railties and AP changelogs with 5.0 release notes.

    [ci skip]
    
    This updates the 5.0 release notes guide to reflect changes that
    happened after beta1 has been released.
    
    I'll sync the other changelogs later today but I'll push this batch to
    prevent against cumbersome merge conflicts.
    senny committed Mar 22, 2016
  14. @amatsuda

    Merge pull request #24269 from bquorning/require-enumerable

    Require enumerable module when using #sum
    amatsuda committed Mar 22, 2016
  15. @bquorning

    Require enumerable module when using #sum

    In rails@dfa48f2,
    a call to `#sum` was added. For that to always work, we need to require the
    core_ext/enumerable module.
    bquorning committed Mar 22, 2016
  16. @maclover7

    Merge pull request #24261 from y-yagi/update_default_adapter

    update Active Job default adapter [ci skip]
    maclover7 committed Mar 21, 2016
Commits on Mar 21, 2016
  1. @y-yagi

    update Active Job default adapter [ci skip]

    Follow up to 625baa6
    y-yagi committed Mar 21, 2016
  2. @jeremy

    Merge pull request #24258 from jeremy/cable/faye-and-isolated-tests

    Cable: add isolated tests and FAYE=1 test runs
    jeremy committed Mar 21, 2016
  3. @kaspth

    Merge pull request #24253 from y-yagi/change_default_value_of_caching

    changed default value of `caching` option to `nil`
    kaspth committed Mar 21, 2016
  4. @arthurnn

    Merge pull request #24243 from dewski/dont-upgrade-file-watcher

    Comment out config.file_watcher during Rails upgrade process
    arthurnn committed Mar 21, 2016
  5. @arthurnn

    Add tests for file_watcher config on update

    [related #24243]
    arthurnn committed Mar 21, 2016
  6. @rafaelfranca
  7. @rafaelfranca

    Merge pull request #24231 from hallmatt/master

    switched layout :mailer to a string so that mail layout can be properly sent
    rafaelfranca committed Mar 21, 2016
  8. @rafaelfranca
  9. @rafaelfranca

    Merge pull request #24229 from maclover7/fix-24222

    Fix request.reset_session for API controllers
    rafaelfranca committed Mar 21, 2016
  10. @jeremy

    Gracefully handle disconnected clients

    We'll get `Errno::ECONNRESET` if the client forcibly disconnected.
    Just close the socket rather than raising the exception.
    
    Handle other errors in `ClientSocket#write`, too, mirroring the Faye
    error handling which swallows all `StandardError` on write.
    jeremy committed Mar 20, 2016
  11. @jeremy
Commits on Mar 20, 2016
  1. @y-yagi

    changed default value of `caching` option to `nil`

    The default is that's false, caching even if you do not specify the caching option is determined not to use,
    and `tmp/caching-dev.txt` will be deleted.
    If it is this, regardless of whether or not there is `tmp/caching-dev.txt`, be sure to order would be necessary to specify the caching option,
    I think that in than good to so as not to do anything by default.
    y-yagi committed Mar 20, 2016
Something went wrong with that request. Please try again.