New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive file adding does not work #8

Closed
marius-wieschollek opened this Issue Dec 22, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@marius-wieschollek

marius-wieschollek commented Dec 22, 2016

Python version: 2.7.12
wx.Python version: 3.0.2
Debreate version: 0.7.12
Platform: Ubuntu 14/16 LTS

In debreate 0.7.10 you could add all the files of a folder recursively to your package on the files page and the folder structure was kept. Now it adds all files to the same folder and ignores the structure.

Step to reproduce

  1. Create new project
  2. Go to "files" page
  3. Select a folder with subfolders from your computer
  4. Click the "add" button

Expected behaviour
All files are added with the original folder structure as in the selected folder

Actual behaviour
All files are added to the "Target" folder and the folder structure is ignored

@AntumDeluge

This comment has been minimized.

Show comment
Hide comment
@AntumDeluge

AntumDeluge Dec 23, 2016

Owner

Thank you for reporting this. It has been fixed in commit 9eb138a.

I will leave this report open for the time being in case of errors in the new code.

Owner

AntumDeluge commented Dec 23, 2016

Thank you for reporting this. It has been fixed in commit 9eb138a.

I will leave this report open for the time being in case of errors in the new code.

@AntumDeluge

This comment has been minimized.

Show comment
Hide comment
Owner

AntumDeluge commented Jan 13, 2017

@brnW

This comment has been minimized.

Show comment
Hide comment
@brnW

brnW Jan 19, 2017

The folder structure is still ignored with 0.7.13 release.

brnW commented Jan 19, 2017

The folder structure is still ignored with 0.7.13 release.

@AntumDeluge

This comment has been minimized.

Show comment
Hide comment
@AntumDeluge

AntumDeluge Jan 19, 2017

Owner

@brnW Could you please explain the steps you are taking to add directories, & the resulting output. I am unable to reproduce the issue. It works for me as expected.

Owner

AntumDeluge commented Jan 19, 2017

@brnW Could you please explain the steps you are taking to add directories, & the resulting output. I am unable to reproduce the issue. It works for me as expected.

@brnW

This comment has been minimized.

Show comment
Hide comment
@brnW

brnW Jan 20, 2017

CPU : x86_64 (64-bit PAE)
System : Linux Mint 18.1
Python : 2.7.12
wxPython : 3.0.2
Debreate : 0.7.13

  1. Open Debreate
  2. Go to "File" page
  3. Browse to the main project folder on your computer
  4. Then select the /usr folder
  5. Select "Custom"
  6. Write /usr on the custom field
  7. Click the "add" button

Expected behaviour (like 0.7.10 release) : all files are added with the original folder structure as in /usr (for example /usr/bin/mycommand ---> mycommand in /usr/bin)

Actual behaviour (0.7.13) : only "usr" folder is added to /usr target (that is /usr/usr) and the structure is ignored.

If you select all the tree (/usr and subfolders), each file or folder is added in /usr target.
Thanks for this work !

brnW commented Jan 20, 2017

CPU : x86_64 (64-bit PAE)
System : Linux Mint 18.1
Python : 2.7.12
wxPython : 3.0.2
Debreate : 0.7.13

  1. Open Debreate
  2. Go to "File" page
  3. Browse to the main project folder on your computer
  4. Then select the /usr folder
  5. Select "Custom"
  6. Write /usr on the custom field
  7. Click the "add" button

Expected behaviour (like 0.7.10 release) : all files are added with the original folder structure as in /usr (for example /usr/bin/mycommand ---> mycommand in /usr/bin)

Actual behaviour (0.7.13) : only "usr" folder is added to /usr target (that is /usr/usr) and the structure is ignored.

If you select all the tree (/usr and subfolders), each file or folder is added in /usr target.
Thanks for this work !

@AntumDeluge

This comment has been minimized.

Show comment
Hide comment
@AntumDeluge

AntumDeluge Jan 20, 2017

Owner

Okay, if I understand correctly, this issue is different than the original topic.

When adding the directory "usr" to the file list, the directory structure is preserved. It's just that the top-level directory "usr" is not trimmed from the file path names.

So, let's say the added directory "usr" contains the file path "usr/bin/foo" and "usr/share/bar":

usr -- bin -- foo
   |
    -- share -- bar

Setting the target directory to "/usr" and adding the directory results in the file paths being "/usr/usr/bin/foo" and "/usr/usr/share/bar". Whereas in 0.7.10, if I remember correctly, they would have been "/usr/bin/foo" and "/usr/share/bar".

I understand how this could be frustrating. It sounds to me that the answer would be to have an option to preserve the parent directory from all file path names, like the following, so that both behaviors are supported:

treeopts

Leaving "Preserve top-level directories" unchecked would have the behavior of 0.7.10.

Owner

AntumDeluge commented Jan 20, 2017

Okay, if I understand correctly, this issue is different than the original topic.

When adding the directory "usr" to the file list, the directory structure is preserved. It's just that the top-level directory "usr" is not trimmed from the file path names.

So, let's say the added directory "usr" contains the file path "usr/bin/foo" and "usr/share/bar":

usr -- bin -- foo
   |
    -- share -- bar

Setting the target directory to "/usr" and adding the directory results in the file paths being "/usr/usr/bin/foo" and "/usr/usr/share/bar". Whereas in 0.7.10, if I remember correctly, they would have been "/usr/bin/foo" and "/usr/share/bar".

I understand how this could be frustrating. It sounds to me that the answer would be to have an option to preserve the parent directory from all file path names, like the following, so that both behaviors are supported:

treeopts

Leaving "Preserve top-level directories" unchecked would have the behavior of 0.7.10.

@AntumDeluge

This comment has been minimized.

Show comment
Hide comment
@AntumDeluge

AntumDeluge Jan 20, 2017

Owner

Option to preserve top-level directories added. See issue #10

Owner

AntumDeluge commented Jan 20, 2017

Option to preserve top-level directories added. See issue #10

Repository owner locked and limited conversation to collaborators Jan 20, 2017

Repository owner unlocked this conversation Jan 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment