Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastlane files incomplete #726

Closed
rnauber opened this issue Sep 27, 2019 · 4 comments

Comments

@rnauber
Copy link

@rnauber rnauber commented Sep 27, 2019

Platform: Android
Build: v95
Issue:
I was asking at F-Droid why Mindustry does not show up on their curated "latest apps" list:
https://forum.f-droid.org/t/mindustry-not-showing-up-in-latest-apps/7378

It was mentioned that:

  1. there is no summary.txt at https://github.com/Anuken/Mindustry/tree/master/fastlane/metadata/android/en-US
  2. The changelogs corresponding to the build codes are missing, e.g. "89.txt" at https://github.com/Anuken/Mindustry/tree/master/fastlane/metadata/android/en-US/changelogs

If this is fixed, Mindustry might gain some visibility in the F-Droid store...

Thank you,
Richard

@Anuken

This comment has been minimized.

Copy link
Owner

@Anuken Anuken commented Sep 27, 2019

Is the summary F-Droid specific? Fastlane didn't grab it from Play, and as far as I know it's not needed there.

Do the changelogs need to be retroactive? I could set up a changelog copy system.

@rnauber

This comment has been minimized.

Copy link
Author

@rnauber rnauber commented Sep 28, 2019

Is the summary F-Droid specific? Fastlane didn't grab it from Play, and as far as I know it's not needed there.

Reading https://gitlab.com/fdroid/fdroidserver/blob/master/fdroidserver/update.py#L964 makes me think that 'short_description.txt' is equivalent to 'summary.txt'. So I think this is ok, as is.

Do the changelogs need to be retroactive? I could set up a changelog copy system.

Well, I guess a changelog for all versions on F-Droid would suffice. So we need v89, v93 and v94...
I think that this is the last missing piece for getting onto the "latest apps" list!

@Anuken

This comment has been minimized.

Copy link
Owner

@Anuken Anuken commented Oct 2, 2019

Added.

@Anuken Anuken closed this Oct 2, 2019
@rnauber

This comment has been minimized.

Copy link
Author

@rnauber rnauber commented Nov 8, 2019

Hi @Anuken,
for some reason Mindustry is still not listed in F-Droids "latest apps" and the discussion here is inconclusive:
https://forum.f-droid.org/t/mindustry-not-showing-up-in-latest-apps/7378/10

I suspect that the changelog for the latest release has to be present in the fastlane folder before the commit is tagged. So could you please add a 100.txt before tagging the v100 release?
Then Mindustry will be visible on the front page of F-Droid.

Thank you very much,
Richard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.