Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Incompatibility with SQLAlchemy 1.3 #83
Noticed this with the Travis builds of Anyblok / WMS Base falling. Restricting to
I did not investigate further, but I'd be surprised if it were specific to AWB (Anyblok's build seems also to be currently broken on master).
I saw it, I fixed it in the branch pytest, can you confirm that this branch fix it. I will pick it in master and release AnyBlok.
The problem come from the naming convention, since SQLAlchemy 1.3 the name of check constrainte is truncated and finished with a hash value.
the comparison method does not know the hash and can not determine that the truncated name and the full name are the same. What causes the destruction and recreation of the constraint
added a commit
Mar 15, 2019
Took me a while to get back to testing conditions, just gave it a new try: it seems to be fixed in 0.21.3, namely I could lauch all tests of Anyblok / Wms Base (AWB) successfully with SQLAlchemy 1.3.1
For the record, it's still there for me in branch pytest.
@jssuzanne, what would be your suggestion with respect to requirements for AWB ? Should I simply require AnyBlok >= 1.23.1 ? Would I need then to insist on SQLAlchemy >= 1.3 ?