Skip to content

/AnyBlok

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first proposal to improve the README #133

Merged
merged 3 commits into from Nov 22, 2019

Conversation

@GohuHQ
Copy link
Contributor

GohuHQ commented Nov 5, 2019

No description provided.

@GohuHQ GohuHQ requested review from petrus-v and jssuzanne Nov 5, 2019
@petrus-v
petrus-v requested changes Nov 5, 2019
View changes
Copy link
Contributor

petrus-v left a comment

thanks a lot to make project README clear !
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@GohuHQ

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

GohuHQ commented Nov 5, 2019

Thanks @petrus-v for the feedback, i pushed a new version.
@petrus-v
petrus-v reviewed Nov 5, 2019
View changes
README.rst Outdated
Releases and project status are available on Pypi at
https://pypi.python.org/pypi/anyblok.

<<<<<<< HEAD

This comment has been minimized.

Sign in to view
Copy link
@petrus-v

petrus-v Nov 5, 2019

Contributor

oubli de résolution de conflit ?

This comment has been minimized.

Sign in to view
Copy link
@GohuHQ

GohuHQ Nov 6, 2019

Author Contributor

Chelou, ça a dû faire ça au moment du rebase :/
Merci !
@GohuHQ GohuHQ force-pushed the GohuHQ:adding_informations_to_the_readme branch 3 times, most recently from f4c13bf to cac1ed9 Nov 6, 2019
@petrus-v
petrus-v reviewed Nov 8, 2019
View changes
README.rst Outdated
Project Status
--------------

AnyBlok is currently in alpha status and is expected to be fairly

This comment has been minimized.

Sign in to view
Copy link
@petrus-v

petrus-v Nov 8, 2019

Contributor

@jssuzanne do you consider we are still in alpha status ?

This comment has been minimized.

Sign in to view
Copy link
@jssuzanne

jssuzanne Nov 15, 2019

Member

No I think, now it is stable
@petrus-v
petrus-v reviewed Nov 8, 2019
View changes
README.rst Outdated
Contributing (hackers needed!)
------------------------------

AnyBlok is at a very early stage, feel free to fork, talk with core dev, and spread the word!

This comment has been minimized.

Sign in to view
Copy link
@petrus-v

petrus-v Nov 8, 2019

Contributor

@jssuzanne how early stage is it ? we may afraid developer that this project is not ready for production usage

This comment has been minimized.

Sign in to view
Copy link
@jssuzanne

jssuzanne Nov 15, 2019

Member

It is ready for production, it is an old text write by @franckbret in 2015. the result of a longuest evening of presentation of anyblok with beer ;)
@petrus-v

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrus-v commented Nov 8, 2019

Thanks @GohuHQ LGTM as it, open discussion could be in an other PR if you prefer, I was just wondering the state of the project, I agree to say it's quite young framework but would like to mention it's ready for production usage as it does !

@jssuzanne roads to release v1.0 looks close, isn't it ? should we plan a sprint focus on that ?
@GohuHQ GohuHQ force-pushed the GohuHQ:adding_informations_to_the_readme branch from c2f19a8 to e5a7e67 Nov 13, 2019
@jssuzanne

This comment has been minimized.

Sign in to view
Copy link
Member

jssuzanne commented Nov 15, 2019

You should also fix setup.py, because the front and the readme are sent on pypi, or you duplicate front on readme
@GohuHQ

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

GohuHQ commented Nov 15, 2019 •
edited

Ok @jssuzanne . I'll duplicate the content because we want this content on AnyBlok documentation i guess.

But maybe we can avoid adding FRONT.rst content to the long description ?
@jssuzanne

This comment has been minimized.

Sign in to view
Copy link
Member

jssuzanne commented Nov 15, 2019

Yes we may. just keep in mind this duplication
@GohuHQ GohuHQ force-pushed the GohuHQ:adding_informations_to_the_readme branch from e5a7e67 to 8fa11d1 Nov 15, 2019
@jssuzanne
jssuzanne approved these changes Nov 15, 2019
View changes
README.rst Outdated
Project Status
--------------

AnyBlok is currently in alpha status and is expected to be fairly

This comment has been minimized.

Sign in to view
Copy link
@jssuzanne

jssuzanne Nov 15, 2019

Member

No I think, now it is stable
README.rst Outdated
Contributing (hackers needed!)
------------------------------

AnyBlok is at a very early stage, feel free to fork, talk with core dev, and spread the word!

This comment has been minimized.

Sign in to view
Copy link
@jssuzanne

jssuzanne Nov 15, 2019

Member

It is ready for production, it is an old text write by @franckbret in 2015. the result of a longuest evening of presentation of anyblok with beer ;)
doc/FRONT.rst
@@ -105,20 +108,17 @@ Jean-Sébastien Suzanne
Contributors
------------

`Anybox <http://anybox.fr>`_ team:

* Jean-Sébastien Suzanne

This comment has been minimized.

Sign in to view
Copy link
@jssuzanne

jssuzanne Nov 15, 2019

Member

I leaved the the team anybox, and @gracinet too. And why you did not add in contributors list.

Maybi the better is to remove the team level

This comment has been minimized.

Sign in to view
Copy link
@GohuHQ

GohuHQ Nov 15, 2019

Author Contributor

It's already done. Please check the last version at https://github.com/GohuHQ/AnyBlok/tree/adding_informations_to_the_readme
Hugo QUEZADA added 3 commits Nov 5, 2019
Hugo QUEZADA
Improved the README file to give required informations to understand
4cd945b 
what is AnyBlok and to start working with AnyBlok or even working on
AnyBlok.
Hugo QUEZADA
Updated FRONT.rst accordingly to the README so informations are the s…
afbf000 
…ame between README and documentation
Hugo QUEZADA
Removed FRONT.rst content from long description in setup.py to avoid …
Loading status checks…
7f29e07 
…duplicated content in Pypi
@GohuHQ GohuHQ force-pushed the GohuHQ:adding_informations_to_the_readme branch from 8fa11d1 to 7f29e07 Nov 22, 2019
@GohuHQ GohuHQ merged commit 5cd35b6 into AnyBlok:master Nov 22, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrus-v petrus-v

@jssuzanne jssuzanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@GohuHQ @petrus-v @jssuzanne
You can’t perform that action at this time.