Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitted apply_model_schema_on_table method #138

Merged
merged 8 commits into from Nov 21, 2019

Conversation

@AlexTorx
Copy link
Contributor

AlexTorx commented Nov 19, 2019

Splitted apply_model_schema_on_table method into three more consistent parts regarding the different steps of migrating, loading slqlachemy events and reloading.

Originally, the apply_model_schema_on_table gathered either migrations, sqlalchemy ORm events registration and reload check. The execution of the whole method was conditionned by the registry.loadwithoutmigration attribute although sqlalchemy events registration whould not depend on whether system should perform a migration or not but must instead be executed at any time.

This PR is intented at proposing a better separation between migration and sqlalchemy orm events registration.

alexis added 2 commits Nov 18, 2019
…t parts regarding the different steps of migrating, loading slqlachemy events and reloading
@AlexTorx AlexTorx marked this pull request as ready for review Nov 19, 2019
alexis and others added 4 commits Nov 19, 2019
…to sqla-event-listening
.travis.yml Outdated
@@ -69,6 +69,8 @@ install:
- pip install -U pip
- pip install git+https://github.com/jssuzanne/sqlalchemy-utils.git@mssql_and_pymssql#egg=sqlalchemy_utils
- pip install wheel
- if [[ $TRAVIS_PYTHON_VERSION == 'pypy3.5' ]]; then pip install psycopg2cffi; else pip install psycopg2-binary; fi
- if [[ $SQLPYCLIENT == 'pymssql' ]]; then pip install 'pymssql<3.0'; fi

This comment has been minimized.

Copy link
@jssuzanne

jssuzanne Nov 20, 2019

Member

why dont modify the $SQLPYCLIENT ?

This comment has been minimized.

Copy link
@AlexTorx

AlexTorx Nov 20, 2019

Author Contributor

Actually yes it works ! ;) Corrected travis config file to only modify SQLPYCLIENT variable when needed.

alexis
@jssuzanne

This comment has been minimized.

Copy link
Member

jssuzanne commented Nov 20, 2019

Great, a last miss, can you change the changelog

alexis
@AlexTorx

This comment has been minimized.

Copy link
Contributor Author

AlexTorx commented Nov 21, 2019

Great, a last miss, can you change the changelog

Yep, done !

@jssuzanne jssuzanne merged commit e73caa1 into AnyBlok:master Nov 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jssuzanne

This comment has been minimized.

Copy link
Member

jssuzanne commented Nov 21, 2019

Thank for the report and the fix

@AlexTorx AlexTorx mentioned this pull request Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.