New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in @see annotations, added tests #1004

Merged
merged 11 commits into from Oct 1, 2017

Conversation

Projects
None yet
1 participant
@vlastavesely
Contributor

vlastavesely commented Sep 14, 2017

I tried to locate source of problems from #935 but I found a few other problems with see annotation.

Currently I am stuck on problem that @dg had too here: 985. It is about the class named Object. I tested it and problem is not in directloading but in parent resolving. BetterReflection uses this: https://github.com/phpDocumentor/TypeResolver/blob/master/src/TypeResolver.php for resolving parent classes and thus object is resolved as PHP 7.2 typehint and not a class name.

For the moment, I do not know what solution would be the best? Any ideas?

@vlastavesely

This comment has been minimized.

Show comment
Hide comment
@vlastavesely

vlastavesely Sep 26, 2017

Contributor

It looks like the new BR works with Object class correctly. Sadly, there are problems with typehints that need to be fixed :(

Contributor

vlastavesely commented Sep 26, 2017

It looks like the new BR works with Object class correctly. Sadly, there are problems with typehints that need to be fixed :(

@vlastavesely vlastavesely merged commit e381f7c into master Oct 1, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 89.134%
Details

@vlastavesely vlastavesely deleted the nelson branch Oct 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment