New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace camelcase option names #1026

Merged
merged 2 commits into from Apr 23, 2018

Conversation

Projects
None yet
4 participants
@mrtndwrd
Contributor

mrtndwrd commented Nov 20, 2017

Use underscores instead of camelcase to fix problems caused by the fact that Yaml is case insensitive.

Closes #1025 and #1007

@vipinjn24

This comment has been minimized.

vipinjn24 commented Nov 28, 2017

i have updated the code manually to this commit and still the options are not parsed and nothing happened.

@vlastavesely

This comment has been minimized.

Contributor

vlastavesely commented Nov 29, 2017

@vipinjn24 So even with this changes it does not work for you? There must be something on your machine then. Maybe something Windows-related...?

@vipinjn24

This comment has been minimized.

vipinjn24 commented Nov 30, 2017

@vlastavesely i checked with the code and found that the method registerContainerConfiguration from AppKernel class is never called where the configuration is picked.
Is this something windows related?

@vipinjn24

This comment has been minimized.

vipinjn24 commented Dec 1, 2017

ok now i checked the behavior and found that registerContainerConfiguration is called the first time i called apigen after restart but in this case it took my yml file from my current working directory and it now threw some error which i previously posted in #1007 (comment)

Now i ran it after removing the yml file and it started running so i cancelled the job and now again i placed the yml file and after initiating the job found that registerContainerConfiguration in not being called no matter what i do!!!

Update:
ok i deleted _apigen_kernel_cache from temp folder and it again started giving me error. so its caching issue and not restart issue. Testing the issue further.

Update:
Got it to parse the file and i guess theme is also working but visibility levels are still not working. but no worries its what i need from your side. thanks.

@vipinjn24

This comment has been minimized.

vipinjn24 commented Dec 30, 2017

ok why you are not merging this change in the master branch!!!

Its been a while since this pull is requested.

@jankal

This comment has been minimized.

Contributor

jankal commented Apr 6, 2018

@vipinjn24 Is this PR ready for merge (as in stable)?

@vipinjn24

This comment has been minimized.

vipinjn24 commented Apr 22, 2018

@jankal yes this one can be merged.

@jankal jankal merged commit 85290e8 into ApiGen:master Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment