Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UI does not properly obey the "disable roles" feature #1610

Closed
carlesarnal opened this issue Jun 25, 2021 · 9 comments
Closed

The UI does not properly obey the "disable roles" feature #1610

carlesarnal opened this issue Jun 25, 2021 · 9 comments
Assignees
Labels
2.0.x Bug Something isn't working

Comments

@carlesarnal
Copy link
Member

carlesarnal commented Jun 25, 2021

The backend can be configured to disable role based authorization. When the server is configured in that way, authentication credentials are required, but roles are ignored - meaning that any authenticated user can preform any action. The UI currently does not support that configuration. The UI assumes that if authentication is enabled, then role based authorization is also enabled.

@carlesarnal carlesarnal self-assigned this Jun 25, 2021
@carlesarnal carlesarnal added the Bug Something isn't working label Jun 28, 2021
@EricWittmann
Copy link
Member

Does this apply to the new security PR or master?

@EricWittmann
Copy link
Member

And can you provide more detail?

@carlesarnal
Copy link
Member Author

Sorry, this applies to 2.0.1 Final as we discussed with Hugo. We have a property in the backend that enabled/disable role checking but the UI is not aware of that property and if authentication is enabled is looking for roles. With the new proposal and or, I think we can probably close this issue.

@EricWittmann
Copy link
Member

OK great - yes the new security approach fixes this issue. We should leave this open to be fixed in the 2.0.x branch (if possible).

@EricWittmann EricWittmann changed the title The UI is not handling the roles enabled property The UI does not properly obey the "disable roles" feature Jun 30, 2021
@carlesarnal
Copy link
Member Author

Closing, this was fixed.

@smccarthy-ie
Copy link
Contributor

@carlesarnal Just to confirm, this was fixed in master and in the 2.0.x branch now also? If so, I can remove it from the downstream Release Notes as a Known Issue. Thanks

@smccarthy-ie
Copy link
Contributor

smccarthy-ie commented Apr 13, 2022

Removed v2.0.x Known Issue from downstream release notes (https://issues.redhat.com/browse/IPT-736)

@carlesarnal
Copy link
Member Author

Sorry @smccarthy-ie, yes, issue fixed.

@smccarthy-ie
Copy link
Contributor

Cool, thanks @carlesarnal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.x Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants