Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added xo as dependency, whitelisted files via package.json #19

Merged
merged 5 commits into from Sep 10, 2017

Conversation

ApoorvSaxena
Copy link
Owner

@ApoorvSaxena ApoorvSaxena commented Sep 10, 2017

in reference to #18

@ApoorvSaxena ApoorvSaxena changed the title 🎨 added xo as dependency, whitelisted files via package.json added xo as dependency, whitelisted files via package.json Sep 10, 2017
package.json Outdated
@@ -28,6 +28,16 @@
"url": "https://github.com/ApoorvSaxena/lozad.js/blob/master/LICENSE"
}
],
"files": [
"dist/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually only the dist should be whitelisted. Otherwise all this others diles will be downloaded every time that someone download lozad from npm. That's only a wast of resources because only the dist files are used when somene require or imports the module.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, fixed

@thiamsantos thiamsantos mentioned this pull request Sep 10, 2017
@ApoorvSaxena ApoorvSaxena merged commit 6e66018 into master Sep 10, 2017
@ApoorvSaxena ApoorvSaxena deleted the package-json-cleanup branch September 24, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants