Skip to content

/ appimage.github.io

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Cool_Reader #927

Open
wants to merge 2 commits into
base: master
from
Open

Create Cool_Reader #927

wants to merge 2 commits into from

Conversation

@Symbian9
Copy link

@Symbian9 Symbian9 commented Nov 11, 2018

Add @EXLMOTODEV's AppImage builds of Cool Reader.
@Symbian9
Create Cool_Reader
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e8094ee
@probonopd
Copy link
Member

@probonopd probonopd commented Nov 11, 2018

Thanks for submitting. Looks like it is missing a png icon. There is only an xpm icon, which is not ideal and currently fails the automated test.
@Symbian9
Copy link
Author

@Symbian9 Symbian9 commented Nov 11, 2018

There is only an xpm icon

Hm, there are not only XPM, but PNG and ICO icons too

@EXLMOTODEV, could you fix your AppImage build according this issue?
EXLMOTODEV pushed a commit to EXLMOTODEV/coolreader that referenced this pull request Nov 11, 2018
@EXL
Choose PNG icon for AppImage instead of XPM icon
Loading status checks…
74adc35 
See:
1) AppImage/appimage.github.io#927
2) https://github.com/probonopd/linuxdeployqt/blob/3381c6c66717e22244951bbba2a080ee74954c5c/tools/linuxdeployqt/main.cpp#L295
@EXL
Copy link

@EXL EXL commented Dec 17, 2018

@EXLMOTODEV, could you fix your AppImage build according this issue?

@Symbian9 yes
The new AppImage release version of Cool Reader app uses the PNG format icon:
https://github.com/EXLMOTODEV/coolreader/releases
@probonopd
Update Cool_Reader
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ab90ad8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Symbian9 @probonopd @EXL
You can’t perform that action at this time.