Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Cool_Reader #927

Closed
wants to merge 2 commits into from
Closed

Create Cool_Reader #927

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 11, 2018

Add @EXLMOTODEV's AppImage builds of Cool Reader.

@probonopd
Copy link
Member

Thanks for submitting. Looks like it is missing a png icon. There is only an xpm icon, which is not ideal and currently fails the automated test.

@ghost
Copy link
Author

ghost commented Nov 11, 2018

There is only an xpm icon

Hm, there are not only XPM, but PNG and ICO icons too

@EXLMOTODEV, could you fix your AppImage build according this issue?

EXLMOTODEV pushed a commit to EXL/coolreader that referenced this pull request Nov 11, 2018
@EXL
Choose PNG icon for AppImage instead of XPM icon
74adc35 
See:
1) AppImage/appimage.github.io#927
2) https://github.com/probonopd/linuxdeployqt/blob/3381c6c66717e22244951bbba2a080ee74954c5c/tools/linuxdeployqt/main.cpp#L295
@EXL
Copy link

EXL commented Dec 17, 2018

@EXLMOTODEV, could you fix your AppImage build according this issue?

@Symbian9 yes
The new AppImage release version of Cool Reader app uses the PNG format icon:
https://github.com/EXLMOTODEV/coolreader/releases

@ghost ghost closed this by deleting the head repository Dec 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@probonopd @EXL