Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to fetch version during runtime #126

Open
TheAssassin opened this issue Jun 3, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@TheAssassin
Copy link
Member

commented Jun 3, 2019

When #124 is done, we should add a method returning a version string for use on runtime. Might come in handy when displaying versions.

@azubieta

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

I guess that we decided to not doing this on #97
Please review.

@TheAssassin

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

Version string != available features. This is mostly useful for about dialogs, bug reports, etc. For instance, I'd like to display some library versions in AppImageLauncher's settings dialog to ease bug reporting in the future.

To me, returning the contents of a #define would be fine, too, but the abstraction of having a function allows for future changes (e.g., adding feature names or so to the version string (not for use to check for features)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.