Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review PayloadIterator public interface #65

Open
azubieta opened this issue Feb 13, 2019 · 2 comments
Open

Review PayloadIterator public interface #65

azubieta opened this issue Feb 13, 2019 · 2 comments

Comments

@azubieta
Copy link
Member

@azubieta azubieta commented Feb 13, 2019

The PayloadIterator provides an SLT friendly interface to traverse the files contained in the AppImage payload. It directly provides access to the entry path by means of operator*() and to the rest of entry properties by means of other function in the same class. This design mostly influenced by the limitations of libarchive and squashfuse.

Creating PayloadEntry objects seems to be a wrong approach as our back-end doesn't allow to keep references to a single entry while traversing.

This issue was opened to give another review to the design.

@azubieta azubieta mentioned this issue Feb 13, 2019
@azubieta azubieta added this to the rewrite-stable-release milestone Feb 13, 2019
@azubieta

This comment has been minimized.

Copy link
Member Author

@azubieta azubieta commented Feb 13, 2019

Continuation of #33 (comment).

@azubieta

This comment has been minimized.

Copy link
Member Author

@azubieta azubieta commented Feb 21, 2019

In relation to having an Entry class mentioned at #74 (comment)

Such class will have to be limited to a simple header. Including the contents will bloat the memory in case of large files. Also as I said in the issue description due to backend limitations you can only extract the information of entry while it's being traversed. Once the traversal moves forward those operations are not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.