Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved sw600 builtin layout support #859

Closed
gyund opened this issue Aug 28, 2020 · 2 comments · Fixed by #878
Closed

improved sw600 builtin layout support #859

gyund opened this issue Aug 28, 2020 · 2 comments · Fixed by #878
Labels
feature request PR related to a potential feature good first issue Issue that are great to pickup for newcomers
Milestone

Comments

@gyund
Copy link

gyund commented Aug 28, 2020

AppIntro Version: 6.0.0

Device/Android Version: N/A

Issue details / Repro steps / Use case background:
This intro is great out of the box! The one thing I would suggest adding is layouts for tablets is larger area for the imageDrawable. It seems to be an imageView that works fine for phones but since the size is the same, it is small on a tablet (tempted to make it bigger right now though). There's a ton of real-estate :)

I would also say font size as well but not sure if that would cause accessibility issues for people already using scaled fonts and it could be app specific (depending on the amount of text of people already using this). At that point, it's probably just better to sub in your own fragment maybe, but a bit of work for just a few size changes to an already nice setup.

Your Code: N/A

Stack trace / LogCat:

N/A
@gyund gyund changed the title sw600 builtin layout support improved sw600 builtin layout support Aug 28, 2020
@cortinico
Copy link
Member

This intro is great out of the box! The one thing I would suggest adding is layouts for tablets is larger area for the imageDrawable. It seems to be an imageView that works fine for phones but since the size is the same, it is small on a tablet (tempted to make it bigger right now though). There's a ton of real-estate :)

Do you have a screenshot to share?

At that point, it's probably just better to sub in your own fragment maybe, but a bit of work for just a few size changes to an already nice setup.

Agree on this. We already have problems on people using big blocks of texts that gets truncated at the third line. Ideally a custom layout would do the job on that front.

@gyund
Copy link
Author

gyund commented Aug 29, 2020

@cortinico cortinico added feature request PR related to a potential feature good first issue Issue that are great to pickup for newcomers labels Aug 30, 2020
@cortinico cortinico added this to the 6.1.0 milestone Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request PR related to a potential feature good first issue Issue that are great to pickup for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants