From 650e00b02d7d289dc40bcb8436384d0cd0f252bf Mon Sep 17 00:00:00 2001 From: Gianpaolo Sinatra Date: Tue, 23 Jan 2024 16:04:18 +0100 Subject: [PATCH 1/3] Add data-tracking attributes to language switcher and login buttons --- src/features/LangMenu.tsx | 3 +++ src/features/LoginForm/LoginFields.tsx | 5 +++++ .../GettingStarted/NewSignupForm/Step0/index.tsx | 7 ++++++- .../GettingStarted/NewSignupForm/Step1/index.tsx | 13 +++++++++++-- src/pages/GettingStarted/index.tsx | 7 +++++++ src/pages/SignupSuccess/index.tsx | 1 + 6 files changed, 33 insertions(+), 3 deletions(-) diff --git a/src/features/LangMenu.tsx b/src/features/LangMenu.tsx index 5064a1083..0626a2906 100644 --- a/src/features/LangMenu.tsx +++ b/src/features/LangMenu.tsx @@ -55,6 +55,7 @@ export const LangMenu = ({
  • { size="block" flat data-qa="login-facebook-button" + data-tracking="facebook-login-cta" onClick={() => { window.location.href = `/wp-admin/admin-ajax.php?loc=${ redirectTo ? redirectTo : pathname @@ -66,6 +67,7 @@ const LoginFields = ({ cta, error }: LoginFieldsProps) => { size="block" flat data-qa="login-linkedin-button" + data-tracking="linkedin-login-cta" onClick={() => { window.location.href = `/wp-admin/admin-ajax.php?loc=${ redirectTo ? redirectTo : pathname @@ -144,6 +146,7 @@ const LoginFields = ({ cta, error }: LoginFieldsProps) => { {t("forgot your password?")} @@ -154,6 +157,7 @@ const LoginFields = ({ cta, error }: LoginFieldsProps) => { size="block" type="submit" formNoValidate + data-tracking="email-pass-login-cta" > {isSubmitting ? t("wait...") : cta} @@ -165,6 +169,7 @@ const LoginFields = ({ cta, error }: LoginFieldsProps) => { strong: , signuplink: ( { - diff --git a/src/pages/GettingStarted/NewSignupForm/Step1/index.tsx b/src/pages/GettingStarted/NewSignupForm/Step1/index.tsx index 6be3d80ca..a44deac72 100644 --- a/src/pages/GettingStarted/NewSignupForm/Step1/index.tsx +++ b/src/pages/GettingStarted/NewSignupForm/Step1/index.tsx @@ -124,7 +124,10 @@ const Step1 = () => { meta, }: FieldProps) => { return ( -
    +
    { /> - diff --git a/src/pages/GettingStarted/index.tsx b/src/pages/GettingStarted/index.tsx index a0fb7780d..ce35c767a 100644 --- a/src/pages/GettingStarted/index.tsx +++ b/src/pages/GettingStarted/index.tsx @@ -55,6 +55,7 @@ export default function GettingStarted() { className="aq-mb-3" size="block" flat + data-tracking="facebook-signup-cta" > ), privacy_link: ( @@ -119,6 +123,7 @@ export default function GettingStarted() { } )} target="_blank" + data-tracking="privacy-policy-link" /> ), ethical_link: ( @@ -128,6 +133,7 @@ export default function GettingStarted() { ns: "links", })} target="_blank" + data-tracking="ethical-code-link" /> ), }} @@ -143,6 +149,7 @@ export default function GettingStarted() { to={login} data-qa="login" style={{ textDecoration: "none" }} + data-tracking="login-link" /> ), strong: , diff --git a/src/pages/SignupSuccess/index.tsx b/src/pages/SignupSuccess/index.tsx index e3117a382..67994f2d5 100644 --- a/src/pages/SignupSuccess/index.tsx +++ b/src/pages/SignupSuccess/index.tsx @@ -73,6 +73,7 @@ export default function SignupSuccess() { kind="primary" size="block" onClick={goToDashboard} + data-tracking="go-to-dashboard-cta" > {t("Go to dashboard")} From cce0ac61f237c10d12b78ec53e52b2286904f0ac Mon Sep 17 00:00:00 2001 From: Gianpaolo Sinatra Date: Tue, 23 Jan 2024 16:34:37 +0100 Subject: [PATCH 2/3] chore: Update appquality-design-system to version 1.0.68 --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index ffa0e39e9..0bcaad9f2 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "version": "0.2.0", "private": true, "dependencies": { - "@appquality/appquality-design-system": "^1.0.67", + "@appquality/appquality-design-system": "^1.0.68", "@appquality/craft-blocks": "^0.1.27", "@datadog/browser-logs": "^3.4.1", "@reduxjs/toolkit": "^1.8.2", diff --git a/yarn.lock b/yarn.lock index e8d126e06..338e40541 100644 --- a/yarn.lock +++ b/yarn.lock @@ -47,10 +47,10 @@ ajv-draft-04 "^1.0.0" call-me-maybe "^1.0.1" -"@appquality/appquality-design-system@^1.0.67": - version "1.0.67" - resolved "https://registry.yarnpkg.com/@appquality/appquality-design-system/-/appquality-design-system-1.0.67.tgz#e822454a7c7345f3a699087c80b1ae9567bf7c89" - integrity sha512-uIEJrX+PgVc4yF/4ciFYuqnP9v78PtYRpSfHx42/iEmI9qx2bFXuxuAgU8003+DBdmb33A7LLe0k0axoLUNLuA== +"@appquality/appquality-design-system@^1.0.68": + version "1.0.68" + resolved "https://registry.yarnpkg.com/@appquality/appquality-design-system/-/appquality-design-system-1.0.68.tgz#ae9c8d385fa8ed4a239a9f513c55922c6e6d0733" + integrity sha512-UYoGphqfGuhEZMocLpEjkJBlUYBST4omjx1YOgVHuyYM3nbqY+pOHQZwsBnRP6+voPY/AjYbTUAjBXMz00tR5w== dependencies: "@appquality/mobiscroll" "^5.10.1" formik "^2.2.9" From 6a60503a36c5e2050ebea33b9509a5cfe1834919 Mon Sep 17 00:00:00 2001 From: Gianpaolo Sinatra Date: Wed, 24 Jan 2024 08:57:23 +0100 Subject: [PATCH 3/3] Add data-tracking attributes to links in Step1 component --- src/pages/GettingStarted/NewSignupForm/Step1/index.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pages/GettingStarted/NewSignupForm/Step1/index.tsx b/src/pages/GettingStarted/NewSignupForm/Step1/index.tsx index a44deac72..f61a45d67 100644 --- a/src/pages/GettingStarted/NewSignupForm/Step1/index.tsx +++ b/src/pages/GettingStarted/NewSignupForm/Step1/index.tsx @@ -160,6 +160,7 @@ const Step1 = () => { ns: "links", })} target="_blank" + data-tracking="terms-condictions-link" /> ), privacy_link: ( @@ -169,6 +170,7 @@ const Step1 = () => { ns: "links", })} target="_blank" + data-tracking="privacy-policy-link" /> ), ethical_link: ( @@ -178,6 +180,7 @@ const Step1 = () => { ns: "links", })} target="_blank" + data-tracking="ethical-code-link" /> ), }}