Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new-style networks for Marathon #54

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@agaffney
Copy link
Contributor

commented Aug 2, 2019

No description provided.

@agaffney agaffney force-pushed the PD-4771-marathon-network-syntax branch from ebe3a70 to e1ede70 Aug 2, 2019

@wolf31o2
Copy link
Contributor

left a comment

Approving, unless you want to fix the TODO.

tmp_network['mode'] = 'host'
else:
# TODO: do something meaningful for unknown network mode
pass

This comment has been minimized.

Copy link
@wolf31o2

wolf31o2 Aug 2, 2019

Contributor

Maybe just fail, instead? Or simply return whatever was given.

This comment has been minimized.

Copy link
@agaffney

agaffney Aug 2, 2019

Author Contributor

A value that's valid for container.docker.network isn't valid for networks.mode (which is why there's a translation), and adding a failure here can open a bigger can of worms (specifying valid values for parameters).

@agaffney agaffney merged commit 129ea24 into master Aug 2, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@agaffney agaffney deleted the PD-4771-marathon-network-syntax branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.