Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ubuntu #3

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@wolf31o2
Copy link
Contributor

commented Jun 4, 2019

Add support for Debian and Ubuntu. However, this has only been tested on
Ubuntu 16.04 and 18.04 LTS releases. YMMV

Signed-off-by: Chris Gianelloni cgianelloni@applause.com

Support Ubuntu
Add support for Debian and Ubuntu. However, this has only been tested on
Ubuntu 16.04 and 18.04 LTS releases. YMMV

Signed-off-by: Chris Gianelloni <cgianelloni@applause.com>
Show resolved Hide resolved recipes/default.rb
if node['platform'] == 'debian'
node['platform_version'].to_i
else
node['platform_version'].to_f

This comment has been minimized.

Copy link
@agaffney

agaffney Jun 4, 2019

Is the to_f even necessary since this value gets converted back to a string when used below?

This comment has been minimized.

Copy link
@wolf31o2

wolf31o2 Jun 5, 2019

Author Contributor

It's to ensure it's only the major.minor and not the patch level. I could have split/joined, but this is faster. Yay dynamic types! 😁

This comment has been minimized.

Copy link
@agaffney

agaffney Jun 5, 2019

Did Ruby go to the MySQL school of data conversion/truncation?

$ irb
irb(main):001:0> '1.2.3'.to_f
=> 1.2

@wolf31o2 wolf31o2 merged commit 4353564 into master Jun 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wolf31o2 wolf31o2 deleted the ubuntu-support branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.