New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger 2.9.0.8 stack access does not trigger BPM #445

Open
peterferrie opened this Issue Jul 25, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@peterferrie

peterferrie commented Jul 25, 2017

Setting a memory breakpoint on a stack location does not cause a breakpoint to be raised when the memory is accessed via PHA/PLA/JSR/RTS.
It would help me to have support for this when tracing interpreted code so that I don't have to single-step until a parameter is popped, for example.

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Jul 27, 2017

Contributor

Hey, Peter I must of been reading your mind because I was about to ask you what debugger features would you like see next? :-)

It looks like none of the 65C02 stack operations will trigger the BP either. :-/

i.e.

BPM 180

300:BA        tsx
301:8E 09 03  stx $309 ; *** SELF-MODIFIES
304:A2 FF     ldx #$80
306:9A        txs
307:DA        phx     ; STX $180 bp not triggered 
308:A2 00     ldx #00 ; *** SELF-MODIFIED
30A:9A        txs
30B:60        rts

300:BA 8E 09 03 A2 FF 9A DA A2 00 9A 60

Contributor

Michaelangel007 commented Jul 27, 2017

Hey, Peter I must of been reading your mind because I was about to ask you what debugger features would you like see next? :-)

It looks like none of the 65C02 stack operations will trigger the BP either. :-/

i.e.

BPM 180

300:BA        tsx
301:8E 09 03  stx $309 ; *** SELF-MODIFIES
304:A2 FF     ldx #$80
306:9A        txs
307:DA        phx     ; STX $180 bp not triggered 
308:A2 00     ldx #00 ; *** SELF-MODIFIED
30A:9A        txs
30B:60        rts

300:BA 8E 09 03 A2 FF 9A DA A2 00 9A 60

@peterferrie

This comment has been minimized.

Show comment
Hide comment
@peterferrie

peterferrie Jul 28, 2017

peterferrie commented Jul 28, 2017

@tomcw tomcw self-assigned this Aug 1, 2017

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Aug 1, 2017

Contributor

Michael - can I take this?

Contributor

tomcw commented Aug 1, 2017

Michael - can I take this?

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Aug 4, 2017

Contributor

Peter - here's a new build, 1.26.3.0, which should help with this issue - at least it will trap on stack accesses for these opcodes: PHA/PLA/JSR/RTS.

Even if you confirm it works, I will leave this issue open, as I want to clean-up the implementation & add some unit-tests.

Contributor

tomcw commented Aug 4, 2017

Peter - here's a new build, 1.26.3.0, which should help with this issue - at least it will trap on stack accesses for these opcodes: PHA/PLA/JSR/RTS.

Even if you confirm it works, I will leave this issue open, as I want to clean-up the implementation & add some unit-tests.

@peterferrie

This comment has been minimized.

Show comment
Hide comment
@peterferrie

peterferrie Aug 4, 2017

peterferrie commented Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment