New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing Addresses, Colon, and OP codes on the debugger code display #462

Closed
TommyGH opened this Issue Aug 15, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@TommyGH

TommyGH commented Aug 15, 2017

With the click of a mouse button, the addresses disappear.
With another click of the mouse button, the colons (":") change to spaces (" ").
With another click of the mouse button, the OP codes disappear.

noaddresses2

noaddresses5

For the life of me I could not figure out why sometimes my disassembly view in the debugger would change. And it took me awhile to figure out how to get some of them back to normal ("disasm OPCODE 1", "disasm COLON 1"). But when the addresses disappeared, I thought the only way to get them back was to restart AppleWin.

Today I discovered the undocumented(?) feature. See the attached images. The "hot spot" is on the left of the screen.

noaddresses4

To someone unfamiliar with this feature, it is EXTREMELY difficult to understand why all of a sudden your display has changed. I usually have multiple windows open at the same time, and I sometimes misclick the mouse button where I should not. Perhaps I'm trying to resize another applications window by dragging it's edge, and I misclick by a few pixels and hit the "hot spot" instead. BAM!! there go my opcodes.

I also imagine more than once I tried to "copy" some text from the "hot spot" of the window, and once again, BAM! there goes my display.

Now that I know about it, I think it is a GREAT feature!!!

But to the unsuspecting user it is BAD! BAD! BAD!

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 16, 2017

Contributor

Yes, this feature is intentional.

There are a couple of action items that need to be done:

  • We could change it to Shift-Click so the user can't accidentally do this.
  • Update the debugger help to document this.
Contributor

Michaelangel007 commented Aug 16, 2017

Yes, this feature is intentional.

There are a couple of action items that need to be done:

  • We could change it to Shift-Click so the user can't accidentally do this.
  • Update the debugger help to document this.
@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 25, 2017

Contributor

Status:

  • WM_LBUTTONDOWN needs to call KeybUpdateCtrlShiftStatus();
  • Add logic in DebuggerMouseClick() to check Alt, Ctrl, Shift with g_bConfigDisasmClick state
    • g_bAltKey
    • g_bCtrlKey
    • g_bShiftKey
  • CmdConfigDisasm() update g_bConfigDisasmClick

Add debugger config support for:

  • disasm click 0 // No Alt, Ctrl, Shift

  • disasm click 1 // Alt

  • disasm click 2 // Ctrl

  • disasm click 3 // Alt+Ctrl

  • disasm click 4 // Shift

  • disasm click 5 // Shift+Alt

  • disasm click 6 // Shift+Ctrl

  • disasm click 7 // Shift+Ctrl+Alt

  • Update help disasm ( 1612269 )

Contributor

Michaelangel007 commented Aug 25, 2017

Status:

  • WM_LBUTTONDOWN needs to call KeybUpdateCtrlShiftStatus();
  • Add logic in DebuggerMouseClick() to check Alt, Ctrl, Shift with g_bConfigDisasmClick state
    • g_bAltKey
    • g_bCtrlKey
    • g_bShiftKey
  • CmdConfigDisasm() update g_bConfigDisasmClick

Add debugger config support for:

  • disasm click 0 // No Alt, Ctrl, Shift

  • disasm click 1 // Alt

  • disasm click 2 // Ctrl

  • disasm click 3 // Alt+Ctrl

  • disasm click 4 // Shift

  • disasm click 5 // Shift+Alt

  • disasm click 6 // Shift+Ctrl

  • disasm click 7 // Shift+Ctrl+Alt

  • Update help disasm ( 1612269 )

Michaelangel007 added a commit that referenced this issue Aug 25, 2017

@Michaelangel007 Michaelangel007 added this to the 1.27 milestone Aug 25, 2017

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 25, 2017

Contributor

NOTE: Need to merge #480 before we can bump debugger version & update docs/Debugger_Changelog.txt

Contributor

Michaelangel007 commented Aug 25, 2017

NOTE: Need to merge #480 before we can bump debugger version & update docs/Debugger_Changelog.txt

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 25, 2017

Contributor

Tommy, another Quality-of-Life feature is #483

Contributor

Michaelangel007 commented Aug 25, 2017

Tommy, another Quality-of-Life feature is #483

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Dec 19, 2017

Contributor

When I start AppleWin, enter debugger (F7) and query the disasm config:
disasm
then it reports
Click: 0 = Left click

Contributor

tomcw commented Dec 19, 2017

When I start AppleWin, enter debugger (F7) and query the disasm config:
disasm
then it reports
Click: 0 = Left click

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Dec 19, 2017

Contributor

OK, changed default to Shift+Click. Now:
disasm
reports:
Click: 4 = Shift Left click

Contributor

tomcw commented Dec 19, 2017

OK, changed default to Shift+Click. Now:
disasm
reports:
Click: 4 = Shift Left click

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Dec 19, 2017

Contributor

@Michaelangel007 - I'll let you complete this issue. You just need to:
Update the debugger help to document this new behaviour.

Contributor

tomcw commented Dec 19, 2017

@Michaelangel007 - I'll let you complete this issue. You just need to:
Update the debugger help to document this new behaviour.

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Jan 6, 2018

Contributor

Bumped debugger version (2.9.0.12) & updated docs/Debugger_Changelog.txt.

Contributor

tomcw commented Jan 6, 2018

Bumped debugger version (2.9.0.12) & updated docs/Debugger_Changelog.txt.

@tomcw tomcw closed this Jan 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment