New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom of screen gets cut off in full screen mode - Windows 10, 1366x768 #464

Closed
NixieLake opened this Issue Aug 16, 2017 · 16 comments

Comments

Projects
None yet
4 participants
@NixieLake

NixieLake commented Aug 16, 2017

I've noticed when I enter full screen mode, the bottom line of text is partially cropped at the bottom. I've been looking around to see if there was any fix for it but couldn't find anyone else complaining about the same problem.

I'm running it on a Windows 10 laptop, Acer Aspire F 15 using Intel HD graphics 620 (onboard).

Thanks

@NixieLake

This comment has been minimized.

Show comment
Hide comment
@NixieLake

NixieLake Aug 16, 2017

Clarification: After comparing each model, I could confirm that it's consistent across each and that the amount of display that seems to be cropped is about 1 or 2 rows of pixels. I'm thinking the full screen mapping might be shifted 1 or 2 rows down because there's a narrow blank space above the emulated display.

NixieLake commented Aug 16, 2017

Clarification: After comparing each model, I could confirm that it's consistent across each and that the amount of display that seems to be cropped is about 1 or 2 rows of pixels. I'm thinking the full screen mapping might be shifted 1 or 2 rows down because there's a narrow blank space above the emulated display.

@sicklittlemonkey

This comment has been minimized.

Show comment
Hide comment
@sicklittlemonkey

sicklittlemonkey Aug 16, 2017

Contributor
Contributor

sicklittlemonkey commented Aug 16, 2017

@NixieLake

This comment has been minimized.

Show comment
Hide comment
@NixieLake

NixieLake Aug 17, 2017

AppleWin ver. 1.26.1.1

NixieLake commented Aug 17, 2017

AppleWin ver. 1.26.1.1

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 17, 2017

Contributor

I'll try setting either my Win7 box or my VMware box to 1366x768 to see if I can repo. but in the meantime is it possible to get a screenshot of this? Thx.

Contributor

Michaelangel007 commented Aug 17, 2017

I'll try setting either my Win7 box or my VMware box to 1366x768 to see if I can repo. but in the meantime is it possible to get a screenshot of this? Thx.

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Aug 18, 2017

Contributor

FYI, using 1.26.3.0, my VAIO laptop at 1600x900 is fine.
I then set the resolution to 1366x768, and yes, the very bottom pixel line is missing.

Contributor

tomcw commented Aug 18, 2017

FYI, using 1.26.3.0, my VAIO laptop at 1600x900 is fine.
I then set the resolution to 1366x768, and yes, the very bottom pixel line is missing.

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Aug 18, 2017

Contributor

Full screen:
(In Paint, I zoomed in at the top, and there is a 5 pixel vertical gap between the edge and the start of the 1st char. Each Apple pixel is 4 Windows pixels, so it seem that the rendering is starting 1 Apple pixel lower than it should.)
text

Windowed:
text-windowed2

Contributor

tomcw commented Aug 18, 2017

Full screen:
(In Paint, I zoomed in at the top, and there is a 5 pixel vertical gap between the edge and the start of the 1st char. Each Apple pixel is 4 Windows pixels, so it seem that the rendering is starting 1 Apple pixel lower than it should.)
text

Windowed:
text-windowed2

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 25, 2017

Contributor

Sorry, been knee-deep in debugger fixes / enhancements. Will try to remember to take a look "soonish".

At least I have that bloody retina resolution for VMWare turned off (aka, pixel doubling is on) so I don't have to squint trying to see a itsy, bitsy, tiny window now.

Contributor

Michaelangel007 commented Aug 25, 2017

Sorry, been knee-deep in debugger fixes / enhancements. Will try to remember to take a look "soonish".

At least I have that bloody retina resolution for VMWare turned off (aka, pixel doubling is on) so I don't have to squint trying to see a itsy, bitsy, tiny window now.

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 26, 2017

Contributor

Confirmed on Windows 7, 1366x768, AppleWin 1.26.3.0

  • Extra 5 px of black on top (VIEWPORTY)
  • Bottom 5 px are cut off (VIEWPORTY)

win7_1366x768

Contributor

Michaelangel007 commented Aug 26, 2017

Confirmed on Windows 7, 1366x768, AppleWin 1.26.3.0

  • Extra 5 px of black on top (VIEWPORTY)
  • Bottom 5 px are cut off (VIEWPORTY)

win7_1366x768

@Michaelangel007 Michaelangel007 self-assigned this Aug 26, 2017

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 26, 2017

Contributor

Ninja'd ! Bug in SetFullScreenMode(), Line 2181

	viewporty  = VIEWPORTY;

Fix is trivial 1-line patch:

	viewporty  = g_bIsFullScreen ? 0 : VIEWPORTY;
Contributor

Michaelangel007 commented Aug 26, 2017

Ninja'd ! Bug in SetFullScreenMode(), Line 2181

	viewporty  = VIEWPORTY;

Fix is trivial 1-line patch:

	viewporty  = g_bIsFullScreen ? 0 : VIEWPORTY;
@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 26, 2017

Contributor

Vars:

A2_WINDOW_HEIGHT: 384
A2_WINDOW_WIDTH : 560

width: 1366
height: 768

scalex: 2
scaley: 2

top : 0
left: 0
Contributor

Michaelangel007 commented Aug 26, 2017

Vars:

A2_WINDOW_HEIGHT: 384
A2_WINDOW_WIDTH : 560

width: 1366
height: 768

scalex: 2
scaley: 2

top : 0
left: 0

@Michaelangel007 Michaelangel007 added this to the 1.27 milestone Aug 26, 2017

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 26, 2017

Contributor

Tagging as 1.27 as a reminder that bin/History.txt needs to be updated.

Contributor

Michaelangel007 commented Aug 26, 2017

Tagging as 1.27 as a reminder that bin/History.txt needs to be updated.

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 26, 2017

Contributor

Is this going to break the fullscreen crosshairs (Joystick) ? DrawCrosshairs () assumes viewport is >= 5 ...

          case 0: OffsetRect(&rect, GetFullScreenOffsetX()+lastx-2,                 GetFullScreenOffsetY()+viewporty-5);             break;
          case 1: OffsetRect(&rect, GetFullScreenOffsetX()+lastx-2,                 GetFullScreenOffsetY()+viewporty+g_nViewportCY); break;
          case 2: OffsetRect(&rect, GetFullScreenOffsetX()+viewportx-5,             GetFullScreenOffsetY()+lasty-2);                 break;
          case 3: OffsetRect(&rect, GetFullScreenOffsetX()+viewportx+g_nViewportCX, GetFullScreenOffsetY()+lasty-2);                 break;
Contributor

Michaelangel007 commented Aug 26, 2017

Is this going to break the fullscreen crosshairs (Joystick) ? DrawCrosshairs () assumes viewport is >= 5 ...

          case 0: OffsetRect(&rect, GetFullScreenOffsetX()+lastx-2,                 GetFullScreenOffsetY()+viewporty-5);             break;
          case 1: OffsetRect(&rect, GetFullScreenOffsetX()+lastx-2,                 GetFullScreenOffsetY()+viewporty+g_nViewportCY); break;
          case 2: OffsetRect(&rect, GetFullScreenOffsetX()+viewportx-5,             GetFullScreenOffsetY()+lasty-2);                 break;
          case 3: OffsetRect(&rect, GetFullScreenOffsetX()+viewportx+g_nViewportCX, GetFullScreenOffsetY()+lasty-2);                 break;
@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Sep 23, 2017

Contributor

Is this going to break the fullscreen crosshairs (Joystick) ?

I now get an assert for the Mousecard with "Restrict mouse to Apple window" unchecked.
I get the assert here:

static void FrameSetCursorPosByMousePos(int x, int y, int dx, int dy, bool bLeavingAppleScreen)
{
   :
	else	// Mouse entering Apple screen area
	{
		:
		_ASSERT(y <= g_nViewportCY);

I'll take a deeper look.

Contributor

tomcw commented Sep 23, 2017

Is this going to break the fullscreen crosshairs (Joystick) ?

I now get an assert for the Mousecard with "Restrict mouse to Apple window" unchecked.
I get the assert here:

static void FrameSetCursorPosByMousePos(int x, int y, int dx, int dy, bool bLeavingAppleScreen)
{
   :
	else	// Mouse entering Apple screen area
	{
		:
		_ASSERT(y <= g_nViewportCY);

I'll take a deeper look.

@tomcw tomcw self-assigned this Sep 23, 2017

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Oct 6, 2017

Contributor

Is this going to break the fullscreen crosshairs (Joystick) ? DrawCrosshairs () assumes viewport is >= 5 ...

I checked void DrawCrosshairs (int x, int y), when the GetFullScreenOffsetY() returns 0 - ie. the full-screen height is 768 (using -fs-height=768).

Anyway this causes OffsetRect() to set rect.top = -5 (return value TRUE / succeeded) and FillRect() to return 1 (succeeded).

So the crosshairs at the top and bottom just don't get draw, but otherwise there's no ill effect.

NB. This only happens when GetFullScreenOffsetY() returns 0, which is only true for a display height of 384 or 768.

I still need to look at that mouse _ASSERT I reported above.

Contributor

tomcw commented Oct 6, 2017

Is this going to break the fullscreen crosshairs (Joystick) ? DrawCrosshairs () assumes viewport is >= 5 ...

I checked void DrawCrosshairs (int x, int y), when the GetFullScreenOffsetY() returns 0 - ie. the full-screen height is 768 (using -fs-height=768).

Anyway this causes OffsetRect() to set rect.top = -5 (return value TRUE / succeeded) and FillRect() to return 1 (succeeded).

So the crosshairs at the top and bottom just don't get draw, but otherwise there's no ill effect.

NB. This only happens when GetFullScreenOffsetY() returns 0, which is only true for a display height of 384 or 768.

I still need to look at that mouse _ASSERT I reported above.

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Oct 10, 2017

Contributor

Closing as ASSERT issue is now fixed.

Contributor

tomcw commented Oct 10, 2017

Closing as ASSERT issue is now fixed.

@tomcw tomcw closed this Oct 10, 2017

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Oct 21, 2017

Contributor

This should be fixed.
Can you try this experimental build: v1.26.3.2.

Contributor

tomcw commented Oct 21, 2017

This should be fixed.
Can you try this experimental build: v1.26.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment