New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long output lines in full console window. Two problems. #476

Closed
TommyGH opened this Issue Aug 20, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@TommyGH

TommyGH commented Aug 20, 2017

In this first image, look at the line starting with "Dup Symbol Name" in the lower half of screen.
Look all the way to the right at the name "A2_USER1.SYM". It would seem the "R" character was dropped as it isn't on the next line either.

screen1

I next did a Ctrl/PrintScrn to capture this as text, and pasted it into Notepad. On the longer lines, after 50 characters are shown, the next character is an inserted space " ". See for example, "A2 _USER1.SYM". I will note that I think 50 is the maximum number of characters in the disassembly window, and the maximum number of characters that are displayed using ECHO from a script.

screen2

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 24, 2017

Contributor
	char sText[ CONSOLE_WIDTH * 3 ];

Debugger_Symbols.cpp, Line 701

					ConsolePrintFormat( sText, " %sDup Symbol Name%s (%s%s%s) %s"
						, CHC_ERROR
						, CHC_DEFAULT
						, CHC_STRING
						, g_aSymbolTableNames[ iTable ]
						, CHC_DEFAULT
						, pPathFileName
Contributor

Michaelangel007 commented Aug 24, 2017

	char sText[ CONSOLE_WIDTH * 3 ];

Debugger_Symbols.cpp, Line 701

					ConsolePrintFormat( sText, " %sDup Symbol Name%s (%s%s%s) %s"
						, CHC_ERROR
						, CHC_DEFAULT
						, CHC_STRING
						, g_aSymbolTableNames[ iTable ]
						, CHC_DEFAULT
						, pPathFileName
@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 24, 2017

Contributor

Repro.:

ConsolePrintFormat( sText, " 23456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789ABC" );

Off-by-one bug in ConsolePrint(), line 150

pSrc++;
Contributor

Michaelangel007 commented Aug 24, 2017

Repro.:

ConsolePrintFormat( sText, " 23456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789ABC" );

Off-by-one bug in ConsolePrint(), line 150

pSrc++;
@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 24, 2017

Contributor

Note: Can NOT use echo for testing:

echo " 23456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789ABC"
Contributor

Michaelangel007 commented Aug 24, 2017

Note: Can NOT use echo for testing:

echo " 23456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789ABC"
@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 24, 2017

Contributor

Tommy, please log a new bug for echo:

i.e. "(Debugger) ECHO is limited to 55 chars"

Contributor

Michaelangel007 commented Aug 24, 2017

Tommy, please log a new bug for echo:

i.e. "(Debugger) ECHO is limited to 55 chars"

@Michaelangel007

This comment has been minimized.

Show comment
Hide comment
@Michaelangel007

Michaelangel007 Aug 25, 2017

Contributor

NOTE: Need to merge #480 before we can pump bump debugger version & update docs/Debugger_Changelog.txt

Contributor

Michaelangel007 commented Aug 25, 2017

NOTE: Need to merge #480 before we can pump bump debugger version & update docs/Debugger_Changelog.txt

@tomcw

This comment has been minimized.

Show comment
Hide comment
@tomcw

tomcw Jan 6, 2018

Contributor

Bumped debugger version (2.9.0.12) & updated docs/Debugger_Changelog.txt.

Contributor

tomcw commented Jan 6, 2018

Bumped debugger version (2.9.0.12) & updated docs/Debugger_Changelog.txt.

@tomcw tomcw closed this Jan 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment